Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draggable AllDay events in WeekView unmovable after dragging bottom most event of stacked events #1173

Closed
lancescape opened this issue Jan 30, 2020 · 6 comments
Labels

Comments

@lancescape
Copy link

lancescape commented Jan 30, 2020

Describe the Bug
In weekView after drag, the drag feature is frozen until manual browser refresh. This is due to mouse drop actually being off zone (mwlDroppable) after execution of redraw of the #allDayEventsContainer. This is only when dragging the bottom most all-day event in a stack.

Due to error, the draggable functionality no longer works until browser refresh is executed.

Minimal reproduction of the problem with instructions
Super simple to replicate. I only added two stacked draggable allDay events to demo code.

https://stackblitz.com/edit/angular-16bn3j

  1. Header drag error - When any all-day event is accidentally dragged in to the header and dropped, the event start/end time is changed. The start becomes the dropped date, and the end is null . Not sure if this is a feature or error.

  2. Timeslot drag error - Similarly when an all-day event is accidentally dragged to mwl-calendar-week-view-hour-segment area of another day, the event end date is set to null. and this is done on the dragEnter state... so if you drag back to the all-day area, it still sets end time as null.

  3. Toast - if you put a toast above the calendar, thus re-positioning the calendar temporarily, drag is not enabled until post disapprears.

Versions
current

I tried various versions of angular-draggable-droppable it is not related to that.

allDayBug

allDayBug

@matts-bot
Copy link

matts-bot bot commented Jan 30, 2020

Thanks so much for opening an issue! If you'd like me to give priority to answering your issue or would just like to support this project, then please consider sponsoring me

@lancescape
Copy link
Author

Updated the issue report with clearer text and gif of bug

@mattlewis92
Copy link
Owner

Hey, thanks so much for making such a detailed bug report, I really appreciate it. I will take a look at this next weekend and see if I can find a solution 😄

@mattlewis92 mattlewis92 added the bug label Mar 1, 2020
@JonasJW
Copy link

JonasJW commented Apr 13, 2020

Hey, I'm having an issue that might be related to this. I tried making the allDay Event Bar larger with these css classes:

.cal-week-view .cal-all-day-events .cal-event {
    height: 60px !important;
}

.cal-all-day-events {
    height: 65px;
}

This way, the drag features stops working with just one allDay event.

@mattlewis92
Copy link
Owner

Hey there, I'm so sorry about the delay with getting to this, please give 0.28.9 a try, this should be fixed now 😄

@lancescape
Copy link
Author

Hey Awesome job! argh I should have figured it was just the drop event in the hour grid.
It works perfectly now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants