fix(week-view): respect minimumEventHeight input when resizing

BREAKING CHANGE:

Previously when resizing events the minimum event height would be calculated based on `hourSegments`, `hourSegmentHeight` and `hourDuration`. It now respects the `minimumEventHeight` input instead.

To restore the old behaviour you will need to set `minimumEventHeight` appropriately (by default it's `30` so should continue to work as expected for most users)

Author: mattlewis92

projects/angular-calendar/src/modules/common/util.ts

@@ -99,17 +99,6 @@ export function getMinutesMoved(
   return draggedInPixelsSnapSize * pixelAmountInMinutes;
 }
 
-export function getMinimumEventHeightInMinutes(
-  hourSegments: number,
-  hourSegmentHeight: number,
-  hourDuration?: number
-) {
-  return (
-    getPixelAmountInMinutes(hourSegments, hourSegmentHeight, hourDuration) *
-    hourSegmentHeight
-  );
-}
-
 export function getDefaultEventEnd(
   dateAdapter: DateAdapter,
   event: CalendarEvent,

projects/angular-calendar/src/modules/week/calendar-week-view.component.ts

@@ -42,7 +42,6 @@ import {
   trackByHour,
   getMinutesMoved,
   getDefaultEventEnd,
-  getMinimumEventHeightInMinutes,
   addDaysWithExclusions,
   isDraggedWithinPeriod,
   shouldFireDroppedEvent,
@@ -1328,29 +1327,24 @@ export class CalendarWeekViewComponent
     calendarEvent: CalendarEvent,
     resizeEvent: ResizeEvent
   ) {
-    const minimumEventHeight = getMinimumEventHeightInMinutes(
-      this.hourSegments,
-      this.hourSegmentHeight,
-      this.hourDuration
-    );
     const newEventDates = {
       start: calendarEvent.start,
       end: getDefaultEventEnd(
         this.dateAdapter,
         calendarEvent,
-        minimumEventHeight
+        this.minimumEventHeight
       ),
     };
     const { end, ...eventWithoutEnd } = calendarEvent;
     const smallestResizes = {
       start: this.dateAdapter.addMinutes(
         newEventDates.end,
-        minimumEventHeight * -1
+        this.minimumEventHeight * -1
       ),
       end: getDefaultEventEnd(
         this.dateAdapter,
         eventWithoutEnd,
-        minimumEventHeight
+        this.minimumEventHeight
       ),
     };
 

projects/angular-calendar/test/calendar-day-view.component.spec.ts

@@ -561,10 +561,10 @@ describe('CalendarDayViewComponent component', () => {
     );
     fixture.componentInstance.viewDate = new Date('2016-06-27');
     fixture.componentInstance.hourSegments = 4;
+    fixture.componentInstance.minimumEventHeight = 15;
     fixture.componentInstance.events = [
       {
         title: 'foo',
-        color: { primary: '', secondary: '' },
         start: moment('2016-06-27').add(4, 'hours').toDate(),
         resizable: {
           afterEnd: true,

projects/angular-calendar/test/calendar-week-view.component.spec.ts

@@ -3090,7 +3090,7 @@ describe('calendarWeekView component', () => {
       clientY: rect.bottom - 200,
     });
     fixture.detectChanges();
-    expect(event.getBoundingClientRect().height).to.equal(20);
+    expect(event.getBoundingClientRect().height).to.equal(1);
     triggerDomEvent('mouseup', document.body, {
       clientX: rect.right,
       clientY: rect.bottom - 200,
@@ -3102,7 +3102,7 @@ describe('calendarWeekView component', () => {
       event: fixture.componentInstance.events[0],
       newStart: fixture.componentInstance.events[0].start,
       newEnd: moment(fixture.componentInstance.events[0].start)
-        .add(30, 'minutes')
+        .add(1, 'minutes')
         .toDate(),
     });
   });
@@ -3159,7 +3159,7 @@ describe('calendarWeekView component', () => {
       clientY: rect.bottom - 120,
     });
     fixture.detectChanges();
-    expect(event.getBoundingClientRect().height).to.equal(20);
+    expect(event.getBoundingClientRect().height).to.equal(1);
     triggerDomEvent('mouseup', document.body, {
       clientX: rect.right,
       clientY: rect.bottom - 120,
@@ -3171,7 +3171,7 @@ describe('calendarWeekView component', () => {
       event: fixture.componentInstance.events[0],
       newStart: fixture.componentInstance.events[0].start,
       newEnd: moment(fixture.componentInstance.events[0].start)
-        .add(20, 'minutes')
+        .add(1, 'minutes')
         .toDate(),
     });
   });