Skip to content

Commit 481eb02

Browse files
committed
feat(week-view): track by a unique row id instead of the index
1 parent fef1b04 commit 481eb02

File tree

3 files changed

+54
-53
lines changed

3 files changed

+54
-53
lines changed

package-lock.json

Lines changed: 45 additions & 44 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132
"dependencies": {
133133
"angular-draggable-droppable": "^4.0.2",
134134
"angular-resizable-element": "^3.2.2",
135-
"calendar-utils": "^0.2.1",
135+
"calendar-utils": "0.3.0-beta.1",
136136
"positioning": "^1.4.0"
137137
},
138138
"sideEffects": [

projects/angular-calendar/src/modules/week/calendar-week-view.component.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ import {
2121
WeekViewHourColumn,
2222
DayViewEvent,
2323
DayViewHourSegment,
24-
DayViewHour
24+
DayViewHour,
25+
WeekViewAllDayEventRow
2526
} from 'calendar-utils';
2627
import { ResizeEvent } from 'angular-resizable-element';
2728
import { CalendarDragHelper } from '../common/calendar-drag-helper.provider';
@@ -33,7 +34,6 @@ import {
3334
import { CalendarUtils } from '../common/calendar-utils.provider';
3435
import {
3536
validateEvents,
36-
trackByIndex,
3737
roundToNearest,
3838
trackByWeekDayHeaderDate,
3939
trackByHourSegment,
@@ -107,7 +107,7 @@ export interface CalendarWeekViewBeforeRenderEvent extends WeekView {
107107
</div>
108108
</div>
109109
<div
110-
*ngFor="let eventRow of view.allDayEventRows; trackBy:trackByIndex"
110+
*ngFor="let eventRow of view.allDayEventRows; trackBy:trackById"
111111
#eventRowContainer
112112
class="cal-events-row">
113113
<div
@@ -533,11 +533,6 @@ export class CalendarWeekViewComponent implements OnChanges, OnInit, OnDestroy {
533533
*/
534534
calendarId = Symbol('angular calendar week view id');
535535

536-
/**
537-
* @hidden
538-
*/
539-
trackByIndex = trackByIndex;
540-
541536
/**
542537
* @hidden
543538
*/
@@ -564,6 +559,11 @@ export class CalendarWeekViewComponent implements OnChanges, OnInit, OnDestroy {
564559
trackByHourColumn = (index: number, column: WeekViewHourColumn) =>
565560
column.hours[0] ? column.hours[0].segments[0].date.toISOString() : column;
566561

562+
/**
563+
* @hidden
564+
*/
565+
trackById = (index: number, row: WeekViewAllDayEventRow) => row.id;
566+
567567
/**
568568
* @hidden
569569
*/

0 commit comments

Comments
 (0)