Skip to content

Commit 069d224

Browse files
author
Matt Lewis
committed
revert: undo the easier event and date formatter config as it was not aot compatible
1 parent 8dbe8d2 commit 069d224

File tree

2 files changed

+3
-39
lines changed

2 files changed

+3
-39
lines changed

src/calendar.module.ts

+3-7
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,13 @@ import { CalendarDateFormatter } from './providers/calendarDateFormatter.provide
5454
})
5555
export class CalendarModule {
5656

57-
static forRoot({eventTitleFormatter, dateFormatter}:
58-
{eventTitleFormatter?: Provider, dateFormatter?: Provider} = {}): ModuleWithProviders {
59-
60-
eventTitleFormatter = eventTitleFormatter || CalendarEventTitleProvider;
61-
dateFormatter = dateFormatter || CalendarDateFormatter;
57+
static forRoot(): ModuleWithProviders {
6258

6359
return {
6460
ngModule: CalendarModule,
6561
providers: [
66-
eventTitleFormatter,
67-
dateFormatter
62+
CalendarEventTitleProvider,
63+
CalendarDateFormatter
6864
]
6965
};
7066

test/calendarModule.spec.ts

-32
Original file line numberDiff line numberDiff line change
@@ -18,36 +18,4 @@ describe('calendar module', () => {
1818
expect(dateFormatter instanceof CalendarDateFormatter).to.be.true;
1919
});
2020

21-
it('should allow a custom date formatter to be used', () => {
22-
class MyDateFormatter extends CalendarDateFormatter {}
23-
TestBed.configureTestingModule({
24-
imports: [
25-
CalendarModule.forRoot({
26-
dateFormatter: {
27-
provide: CalendarDateFormatter,
28-
useClass: MyDateFormatter
29-
}
30-
})
31-
]
32-
});
33-
const dateFormatter: MyDateFormatter = TestBed.get(CalendarDateFormatter);
34-
expect(dateFormatter instanceof MyDateFormatter).to.be.true;
35-
});
36-
37-
it('should allow a custom title formatter to be used', () => {
38-
class MyEventTitle extends CalendarEventTitle {}
39-
TestBed.configureTestingModule({
40-
imports: [
41-
CalendarModule.forRoot({
42-
dateFormatter: {
43-
provide: CalendarEventTitle,
44-
useClass: MyEventTitle
45-
}
46-
})
47-
]
48-
});
49-
const eventTitle: MyEventTitle = TestBed.get(CalendarEventTitle);
50-
expect(eventTitle instanceof MyEventTitle).to.be.true;
51-
});
52-
5321
});

0 commit comments

Comments
 (0)