Skip to content

Commit 0f30b48

Browse files
Matt Mayermatthewmayer
Matt Mayer
authored and
matthewmayer
committed
fix(person): change fullName to use name patterns (faker-js#1637)
1 parent e50a72b commit 0f30b48

File tree

50 files changed

+350
-237
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+350
-237
lines changed

‎src/definitions/person.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ export type PersonDefinitions = LocaleEntry<{
2626
suffix: string[];
2727

2828
/**
29-
* A list of patterns used to generate names.
29+
* A weighted list of patterns used to generate names.
3030
*/
31-
name: string[];
31+
name: Array<{ value: string; weight: number }>;
3232

3333
bio_patterns?: string[];
3434

‎src/locales/ar/person/name.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}}',
4-
'{{person.last_name}} {{person.first_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 5 },
7+
{ value: '{{person.lastName}} {{person.firstName}}', weight: 5 },
58
];

‎src/locales/az/person/name.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
export default [
2-
'{{person.male_first_name}}',
3-
'{{person.male_last_name}} {{person.male_first_name}}',
4-
'{{person.male_first_name}} {{person.male_last_name}}',
5-
'{{person.female_first_name}}',
6-
'{{person.female_first_name}} {{person.female_last_name}}',
7-
'{{person.female_last_name}} {{person.female_first_name}}',
2+
{ value: '{{person.firstName}}', weight: 1 },
3+
{ value: '{{person.lastName}} {{person.firstName}}', weight: 1 },
4+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 1 },
85
];

‎src/locales/cz/person/name.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
export default [
2-
'{{person.prefix}} {{person.male_first_name}} {{person.male_last_name}}',
3-
'{{person.prefix}} {{person.female_first_name}} {{person.female_last_name}}',
4-
'{{person.male_first_name}} {{person.male_last_name}} {{person.suffix}}',
5-
'{{person.female_first_name}} {{person.female_last_name}} {{person.suffix}}',
6-
'{{person.male_first_name}} {{person.male_last_name}}',
7-
'{{person.female_first_name}} {{person.female_last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{
7+
value: '{{person.firstName}} {{person.lastName}} {{person.suffix}}',
8+
weight: 1,
9+
},
10+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 8 },
811
];

‎src/locales/de/person/name.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.nobility_title_prefix}} {{person.last_name}}',
4-
'{{person.first_name}} {{person.last_name}}',
5-
'{{person.male_first_name}} {{person.last_name}}',
6-
'{{person.female_first_name}} {{person.last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 9 },
77
];

‎src/locales/de_AT/person/name.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.nobility_title_prefix}} {{person.last_name}}',
4-
'{{person.first_name}} {{person.last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 5 },
57
];

‎src/locales/de_CH/person/name.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
export default ['{{person.first_name}} {{person.last_name}}'];
1+
export default [
2+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 1 },
3+
];

‎src/locales/dv/person/name.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
export default [
2-
'{{person.first_name}} {{person.last_name}}',
3-
'{{person.male_first_name}} {{person.male_last_name}}',
4-
'{{person.female_first_name}} {{person.female_last_name}}',
2+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 1 },
53
];

‎src/locales/el/person/name.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}} {{person.suffix}}',
4-
'{{person.first_name}} {{person.last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{
7+
value: '{{person.firstName}} {{person.lastName}} {{person.suffix}}',
8+
weight: 1,
9+
},
10+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 8 },
511
];

‎src/locales/en/person/name.ts

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,16 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}} {{person.suffix}}',
4-
'{{person.first_name}} {{person.last_name}}',
5-
'{{person.male_first_name}} {{person.last_name}}',
6-
'{{person.female_first_name}} {{person.last_name}}',
2+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 49 },
3+
{
4+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
5+
weight: 7,
6+
},
7+
{
8+
value: '{{person.firstName}} {{person.lastName}} {{person.suffix}}',
9+
weight: 7,
10+
},
11+
{
12+
value:
13+
'{{person.prefix}} {{person.firstName}} {{person.lastName}} {{person.suffix}}',
14+
weight: 1,
15+
},
716
];

‎src/locales/en_GH/person/name.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
export default [
2-
'{{person.female_first_name}} {{person.last_name}}',
3-
'{{person.female_first_name}} {{person.last_name}}-{{person.last_name}}',
4-
'{{person.male_first_name}} {{person.last_name}}',
5-
'{{person.male_first_name}} {{person.last_name}}-{{person.last_name}}',
2+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 1 },
3+
{
4+
value: '{{person.firstName}} {{person.lastName}}-{{person.lastName}}',
5+
weight: 1,
6+
},
67
];

‎src/locales/en_NG/person/name.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{person.first_name}} {{person.last_name}}',
3-
'{{person.last_name}} {{person.first_name}}',
2+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 1 },
3+
{ value: '{{person.lastName}} {{person.firstName}}', weight: 1 },
44
];

‎src/locales/en_ZA/person/name.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
export default [
2-
'{{person.first_name}} {{person.last_name}}',
3-
'{{person.last_name}} {{person.first_name}}',
2+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 1 },
3+
{ value: '{{person.lastName}} {{person.firstName}}', weight: 1 },
44
];

‎src/locales/es/person/name.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}} {{person.last_name}}',
2+
{
3+
value:
4+
'{{person.prefix}} {{person.firstName}} {{person.lastName}} {{person.lastName}}',
5+
weight: 1,
6+
},
7+
{
8+
value: '{{person.firstName}} {{person.lastName}} {{person.lastName}}',
9+
weight: 9,
10+
},
411
];

‎src/locales/es_MX/person/name.ts

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,20 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}} de {{person.last_name}}',
4-
'{{person.suffix}} {{person.first_name}} {{person.last_name}} {{person.last_name}}',
5-
'{{person.first_name}} {{person.last_name}} {{person.last_name}}',
2+
{
3+
value:
4+
'{{person.prefix}} {{person.firstName}} {{person.lastName}} {{person.lastName}}',
5+
weight: 1,
6+
},
7+
{
8+
value: '{{person.firstName}} {{person.lastName}} de {{person.lastName}}',
9+
weight: 3,
10+
},
11+
{
12+
value:
13+
'{{person.suffix}} {{person.firstName}} {{person.lastName}} {{person.lastName}}',
14+
weight: 1,
15+
},
16+
{
17+
value: '{{person.firstName}} {{person.lastName}} {{person.lastName}}',
18+
weight: 5,
19+
},
620
];

‎src/locales/fa/person/name.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}}',
4-
'{{person.male_first_name}} {{person.last_name}}',
5-
'{{person.female_first_name}} {{person.last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 9 },
67
];

‎src/locales/fi/person/name.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
export default [
2-
'{{person.first_name}} {{person.last_name}}',
3-
'{{person.male_first_name}} {{person.last_name}}',
4-
'{{person.female_first_name}} {{person.last_name}}',
2+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 1 },
53
];

‎src/locales/fr/person/name.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}}',
4-
'{{person.last_name}} {{person.first_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 2,
5+
},
6+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 8 },
57
];

‎src/locales/fr_BE/person/name.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}} {{person.suffix}}',
4-
'{{person.first_name}} {{person.last_name}}',
5-
'{{person.male_first_name}} {{person.last_name}}',
6-
'{{person.female_first_name}} {{person.last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{
7+
value: '{{person.firstName}} {{person.lastName}} {{person.suffix}}',
8+
weight: 1,
9+
},
10+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 8 },
711
];

‎src/locales/fr_CH/person/name.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}}',
4-
'{{person.last_name}} {{person.first_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 2,
5+
},
6+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 8 },
57
];

‎src/locales/ge/person/name.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 9 },
47
];

‎src/locales/he/person/name.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}}',
4-
'{{person.male_first_name}} {{person.last_name}}',
5-
'{{person.female_first_name}} {{person.last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 9 },
67
];

‎src/locales/hr/person/name.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}}, {{person.suffix}}',
4-
'{{person.first_name}} {{person.last_name}}',
5-
'{{person.male_first_name}} {{person.last_name}}',
6-
'{{person.female_first_name}} {{person.last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{
7+
value: '{{person.firstName}} {{person.lastName}}, {{person.suffix}}',
8+
weight: 1,
9+
},
10+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 8 },
711
];

‎src/locales/hu/person/name.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
export default [
2-
'{{person.prefix}} {{person.last_name}} {{person.first_name}}',
3-
'{{person.last_name}} {{person.first_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.lastName}} {{person.firstName}}',
4+
weight: 1,
5+
},
6+
{ value: '{{person.lastName}} {{person.firstName}}', weight: 9 },
47
];

‎src/locales/hy/person/name.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}} {{person.suffix}}',
4-
'{{person.first_name}} {{person.last_name}}',
5-
'{{person.male_first_name}} {{person.last_name}}',
6-
'{{person.female_first_name}} {{person.last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{
7+
value: '{{person.firstName}} {{person.lastName}} {{person.suffix}}',
8+
weight: 1,
9+
},
10+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 8 },
711
];

‎src/locales/id_ID/person/name.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
export default [
2-
'{{person.male_first_name}} {{person.male_last_name}}',
3-
'{{person.male_last_name}} {{person.male_first_name}}',
4-
'{{person.male_first_name}} {{person.male_first_name}} {{person.male_last_name}}',
5-
'{{person.female_first_name}} {{person.female_last_name}}',
6-
'{{person.female_first_name}} {{person.male_last_name}}',
7-
'{{person.female_last_name}} {{person.female_first_name}}',
8-
'{{person.female_first_name}} {{person.female_first_name}} {{person.female_last_name}}',
2+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 1 },
3+
{ value: '{{person.lastName}} {{person.firstName}}', weight: 1 },
4+
{
5+
value: '{{person.firstName}} {{person.firstName}} {{person.lastName}}',
6+
weight: 1,
7+
},
98
];

‎src/locales/it/person/name.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
export default [
2-
'{{person.prefix}} {{person.first_name}} {{person.last_name}}',
3-
'{{person.first_name}} {{person.last_name}}',
4-
'{{person.male_first_name}} {{person.last_name}}',
5-
'{{person.female_first_name}} {{person.last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 9 },
67
];

‎src/locales/ja/person/name.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
export default ['{{person.last_name}} {{person.first_name}}'];
1+
export default [
2+
{ value: '{{person.lastName}} {{person.firstName}}', weight: 1 },
3+
];

‎src/locales/ko/person/name.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
export default ['{{person.last_name}} {{person.first_name}}'];
1+
export default [
2+
{ value: '{{person.lastName}} {{person.firstName}}', weight: 1 },
3+
];

‎src/locales/lv/person/name.ts

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,20 @@
11
export default [
2-
'{{person.prefix}} {{person.male_first_name}} {{person.male_last_name}}',
3-
'{{person.male_first_name}} {{person.male_last_name}}',
4-
'{{person.male_last_name}} {{person.male_first_name}}',
5-
'{{person.male_first_name}} {{person.male_first_name}} {{person.male_last_name}}',
6-
'{{person.male_first_name}} {{person.male_last_name}}-{{person.male_last_name}}',
7-
'{{person.prefix}} {{person.female_first_name}} {{person.female_last_name}}',
8-
'{{person.female_first_name}} {{person.female_last_name}} {{person.suffix}}',
9-
'{{person.female_first_name}} {{person.female_last_name}}',
10-
'{{person.female_last_name}} {{person.female_first_name}}',
11-
'{{person.female_first_name}} {{person.female_first_name}} {{person.female_last_name}}',
12-
'{{person.female_first_name}} {{person.female_last_name}}-{{person.female_last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{
7+
value: '{{person.firstName}} {{person.lastName}} {{person.suffix}}',
8+
weight: 1,
9+
},
10+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 7 },
11+
{ value: '{{person.lastName}} {{person.firstName}}', weight: 2 },
12+
{
13+
value: '{{person.firstName}} {{person.firstName}} {{person.lastName}}',
14+
weight: 2,
15+
},
16+
{
17+
value: '{{person.firstName}} {{person.lastName}}-{{person.lastName}}',
18+
weight: 2,
19+
},
1320
];

‎src/locales/mk/person/name.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
export default [
2-
'{{person.female_prefix}} {{person.female_first_name}} {{person.female_last_name}}',
3-
'{{person.male_prefix}} {{person.male_first_name}} {{person.male_last_name}}',
4-
'{{person.female_first_name}} {{person.female_last_name}}',
5-
'{{person.male_first_name}} {{person.male_last_name}}',
2+
{
3+
value: '{{person.prefix}} {{person.firstName}} {{person.lastName}}',
4+
weight: 1,
5+
},
6+
{ value: '{{person.firstName}} {{person.lastName}}', weight: 8 },
67
];

0 commit comments

Comments
 (0)