fix: address issue with replaying tx via cast run #1071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Note: Some improvements can still be made, for instance we return
Error function_selector = 0xe8d529f9, data = 0xe8d529f9
as a String and its never decoded via Openchain. We should improve this to do so, then its human readable asOrderFailed()
instead of0xe8d529f9
.Why ✋
Evidence 📷
Include screenshots, screen recordings, or
console
output here demonstrating that your changes work as intendedBEFORE:
NOW:
Documentation 📚
Please ensure the following before submitting your PR: