Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

'apparently some people use access tokens that are not macaroons' #10964

Closed
reivilibre opened this issue Oct 1, 2021 · 1 comment · Fixed by #12577
Closed

'apparently some people use access tokens that are not macaroons' #10964

reivilibre opened this issue Oct 1, 2021 · 1 comment · Fixed by #12577
Assignees
@reivilibre
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@reivilibre
Copy link
Contributor

This comment seems stale, since it now seems like we encourage and use syt_... tokens by default which are not macaroons?

synapse/synapse/api/auth.py

Lines 417 to 418 in 8c7a531

# TODO: it would be nice to get rid of this, but apparently some
# people use access tokens which aren't macaroons

@reivilibre reivilibre added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Oct 1, 2021
@reivilibre reivilibre self-assigned this Oct 1, 2021
@richvdh
Copy link
Member

richvdh commented Oct 1, 2021

yes it is. That comment dates from a period where we were trying to move away from random strings as access tokens, towards macaroons. We've long since aborted that plan.

@AndrewFerr AndrewFerr mentioned this issue Oct 4, 2021
Merged
4 tasks
@reivilibre reivilibre mentioned this issue Apr 28, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@reivilibre reivilibre

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve comments and error messages around access tokens. matrix-org/synapse
2 participants
@richvdh @reivilibre