Quieter logging for stateres failure at missing prev events (#14346)

David Robertson · web-flow · commit d10a85ec9eac · 2022-11-10T12:17:46.000Z
diff --git a/changelog.d/14346.misc b/changelog.d/14346.misc
@@ -0,0 +1 @@
+Concisely log a failure to resolve state due to missing `prev_events`.
diff --git a/synapse/handlers/federation_event.py b/synapse/handlers/federation_event.py
@@ -1065,10 +1065,9 @@ async def _compute_event_context_with_maybe_missing_prevs(
                 state_res_store=StateResolutionStore(self._store),
             )
 
-        except Exception:
+        except Exception as e:
             logger.warning(
-                "Error attempting to resolve state at missing prev_events",
-                exc_info=True,
+                "Error attempting to resolve state at missing prev_events: %s", e
             )
             raise FederationError(
                 "ERROR",

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Concisely log a failure to resolve state due to missing `prev_events`.
Original file line number	Diff line number	Diff line change
`@@ -1065,10 +1065,9 @@ async def _compute_event_context_with_maybe_missing_prevs(`
`1065`	`1065`	`state_res_store=StateResolutionStore(self._store),`
`1066`	`1066`	`)`
`1067`	`1067`
`1068`		`- except Exception:`
	`1068`	`+ except Exception as e:`
`1069`	`1069`	`logger.warning(`
`1070`		`- "Error attempting to resolve state at missing prev_events",`
`1071`		`- exc_info=True,`
	`1070`	`+ "Error attempting to resolve state at missing prev_events: %s", e`
`1072`	`1071`	`)`
`1073`	`1072`	`raise FederationError(`
`1074`	`1073`	`"ERROR",`