Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit b37d7d3

Browse files
committed
Fix-up types for related_events_flattened.
1 parent 9bec3ae commit b37d7d3

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

rust/src/push/evaluator.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ pub struct PushRuleEvaluator {
8585

8686
/// The related events, indexed by relation type. Flattened in the same manner as
8787
/// `flattened_keys`.
88-
related_events_flattened: BTreeMap<String, BTreeMap<String, String>>,
88+
related_events_flattened: BTreeMap<String, BTreeMap<String, SimpleJsonValue>>,
8989

9090
/// If msc3664, push rules for related events, is enabled.
9191
related_event_match_enabled: bool,
@@ -113,7 +113,7 @@ impl PushRuleEvaluator {
113113
room_member_count: u64,
114114
sender_power_level: Option<i64>,
115115
notification_power_levels: BTreeMap<String, i64>,
116-
related_events_flattened: BTreeMap<String, BTreeMap<String, String>>,
116+
related_events_flattened: BTreeMap<String, BTreeMap<String, SimpleJsonValue>>,
117117
related_event_match_enabled: bool,
118118
room_version_feature_flags: Vec<String>,
119119
msc3931_enabled: bool,
@@ -424,7 +424,7 @@ impl PushRuleEvaluator {
424424
return Ok(false);
425425
};
426426

427-
let haystack = if let Some(haystack) = event.get(&**key) {
427+
let haystack = if let Some(SimpleJsonValue::Str(haystack)) = event.get(&**key) {
428428
haystack
429429
} else {
430430
return Ok(false);

stubs/synapse/synapse_rust/push.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class PushRuleEvaluator:
6161
room_member_count: int,
6262
sender_power_level: Optional[int],
6363
notification_power_levels: Mapping[str, int],
64-
related_events_flattened: Mapping[str, Mapping[str, str]],
64+
related_events_flattened: Mapping[str, Mapping[str, SimpleJsonValue]],
6565
related_event_match_enabled: bool,
6666
room_version_feature_flags: Tuple[str, ...],
6767
msc3931_enabled: bool,

synapse/push/bulk_push_rule_evaluator.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,13 +232,15 @@ async def _get_power_levels_and_sender_level(
232232

233233
return pl_event.content if pl_event else {}, sender_level
234234

235-
async def _related_events(self, event: EventBase) -> Dict[str, Dict[str, str]]:
235+
async def _related_events(
236+
self, event: EventBase
237+
) -> Dict[str, Dict[str, SimpleJsonValue]]:
236238
"""Fetches the related events for 'event'. Sets the im.vector.is_falling_back key if the event is from a fallback relation
237239
238240
Returns:
239241
Mapping of relation type to flattened events.
240242
"""
241-
related_events: Dict[str, Dict[str, str]] = {}
243+
related_events: Dict[str, Dict[str, SimpleJsonValue]] = {}
242244
if self._related_event_match_enabled:
243245
related_event_id = event.content.get("m.relates_to", {}).get("event_id")
244246
relation_type = event.content.get("m.relates_to", {}).get("rel_type")

0 commit comments

Comments
 (0)