Disable proactive sends for remote joins (#12330)

Do not attempt to send remote joins out over federation. Normally, it will do
nothing; occasionally, it will do the wrong thing.

Author: richvdh

changelog.d/12330.misc

@@ -0,0 +1 @@
+Avoid trying to calculate the state at outlier events.

synapse/handlers/federation_event.py

@@ -469,6 +469,12 @@ async def process_remote_join(
             if context.rejected:
                 raise SynapseError(400, "Join event was rejected")
 
+            # the remote server is responsible for sending our join event to the rest
+            # of the federation. Indeed, attempting to do so will result in problems
+            # when we try to look up the state before the join (to get the server list)
+            # and discover that we do not have it.
+            event.internal_metadata.proactively_send = False
+
             return await self.persist_events_and_notify(room_id, [(event, context)])
 
     async def backfill(