This repository was archived by the owner on Apr 26, 2024. It is now read-only.
File tree 2 files changed +9
-0
lines changed
2 files changed +9
-0
lines changed Original file line number Diff line number Diff line change @@ -267,6 +267,10 @@ async def get_new_events_as(
267
267
)
268
268
269
269
# Then filter down to rooms that the AS can read
270
+ # TODO: This doesn't seem to honour an appservice's registration of room or
271
+ # namespace aliases. For instance, if an appservice registered a room namespace
272
+ # that matched this room, but it didn't have any members in the room, then that
273
+ # appservice wouldn't receive the read receipt.
270
274
events = []
271
275
for room_id , event in rooms_to_events .items ():
272
276
if not await service .matches_user_in_member_list (room_id , self .store ):
Original file line number Diff line number Diff line change @@ -481,6 +481,11 @@ async def get_new_events_as(
481
481
for room_id in handler ._room_serials .keys ():
482
482
if handler ._room_serials [room_id ] <= from_key :
483
483
continue
484
+
485
+ # TODO: This doesn't seem to honour an appservice's registration of room or
486
+ # namespace aliases. For instance, if an appservice registered a room namespace
487
+ # that matched this room, but it didn't have any members in the room, then that
488
+ # appservice wouldn't receive the typing event.
484
489
if not await service .matches_user_in_member_list (
485
490
room_id , handler .store
486
491
):
You can’t perform that action at this time.
0 commit comments