Added a comment on why there's an extra 'except' block

aytchell · aytchell · commit 71a2589202bb · 2022-06-15T14:46:20.000+02:00
diff --git a/synapse/rest/client/login.py b/synapse/rest/client/login.py
@@ -438,6 +438,7 @@ async def _do_jwt_login(
                 claims_options=claim_options,
             )
         except BadSignatureError:
+            # We handle this case separately to provide a better error message
             raise LoginError(
                 403,
                 "JWT validation failed: Signature verification failed",

Original file line number	Diff line number	Diff line change
`@@ -438,6 +438,7 @@ async def _do_jwt_login(`
`438`	`438`	`claims_options=claim_options,`
`439`	`439`	`)`
`440`	`440`	`except BadSignatureError:`
	`441`	`+ # We handle this case separately to provide a better error message`
`441`	`442`	`raise LoginError(`
`442`	`443`	`403,`
`443`	`444`	`"JWT validation failed: Signature verification failed",`