Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 6df643d

Browse files
committed
Add comment describing why we do not answer make_joins
1 parent 72c3f78 commit 6df643d

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

synapse/handlers/federation.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -752,6 +752,10 @@ async def on_make_join_request(
752752
# If our server is still only partially joined, we can't give a complete
753753
# response to /make_join, so return a 404 as we would if we weren't in the
754754
# room at all.
755+
# The main reason we can't respond properly is that we need to know about
756+
# the auth events for the join event that we would return.
757+
# We should not bother entertaining the make_join since we cannot handle
758+
# the send_join.
755759
logger.info(
756760
"Rejecting /make_join to %s because it's a partial state room", room_id
757761
)

0 commit comments

Comments
 (0)