This repository was archived by the owner on Apr 26, 2024. It is now read-only.
File tree Expand file tree Collapse file tree 1 file changed +3
-11
lines changed
synapse/storage/databases/main Expand file tree Collapse file tree 1 file changed +3
-11
lines changed Original file line number Diff line number Diff line change @@ -2386,6 +2386,9 @@ def mark_event_rejected_txn(
2386
2386
2387
2387
This can happen, for example, when resyncing state during a faster join.
2388
2388
2389
+ It is the caller's responsibility to ensure that other workers are
2390
+ sent a notification so that they call `_invalidate_local_get_event_cache()`.
2391
+
2389
2392
Args:
2390
2393
txn:
2391
2394
event_id: ID of event to update
@@ -2424,14 +2427,3 @@ def mark_event_rejected_txn(
2424
2427
)
2425
2428
2426
2429
self .invalidate_get_event_cache_after_txn (txn , event_id )
2427
-
2428
- # TODO(faster_joins): invalidate the cache on workers. Ideally we'd just
2429
- # call '_send_invalidation_to_replication', but we actually need the other
2430
- # end to call _invalidate_local_get_event_cache() rather than (just)
2431
- # _get_event_cache.invalidate().
2432
- #
2433
- # One solution might be to (somehow) get the workers to call
2434
- # _invalidate_caches_for_event() (though that will invalidate more than
2435
- # strictly necessary).
2436
- #
2437
- # https://github.com/matrix-org/synapse/issues/12994
You can’t perform that action at this time.
0 commit comments