Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 57fac2a

Browse files
author
David Robertson
authored
Allow unused ignores in "bleeding edge" CI (#12576)
* Allow unused ignores in "bleeding edge" CI Where "bleeding edge" means the Twisted Trunk and Latest Deps jobs. Follow up from #12531. Resolves #12574. * Use `--extras all` in latest deps mypy CI Twisted trunk job already does this. Missed in #12531. * changelog
1 parent 3ae56d1 commit 57fac2a

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

.github/workflows/latest_deps.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,15 @@ jobs:
3232
with:
3333
python-version: "3.x"
3434
poetry-version: "1.2.0b1"
35+
extras: "all"
3536
# Dump installed versions for debugging.
3637
- run: poetry run pip list > before.txt
3738
# Upgrade all runtime dependencies only. This is intended to mimic a fresh
3839
# `pip install matrix-synapse[all]` as closely as possible.
3940
- run: poetry update --no-dev
4041
- run: poetry run pip list > after.txt && (diff -u before.txt after.txt || true)
42+
- name: Remove warn_unused_ignores from mypy config
43+
run: sed '/warn_unused_ignores = True/d' -i mypy.ini
4144
- run: poetry run mypy
4245
trial:
4346
runs-on: ubuntu-latest

.github/workflows/twisted_trunk.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ jobs:
2424
poetry remove twisted
2525
poetry add --extras tls git+https://github.com/twisted/twisted.git#trunk
2626
poetry install --no-interaction --extras "all test"
27+
- name: Remove warn_unused_ignores from mypy config
28+
run: sed '/warn_unused_ignores = True/d' -i mypy.ini
2729
- run: poetry run mypy
2830

2931
trial:

changelog.d/12576.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Allow unused `#type: ignore` comments in bleeding edge CI jobs.

0 commit comments

Comments
 (0)