Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 300be44

Browse files
committed
Fix-up types for related_events_flattened.
1 parent 40c8d4d commit 300be44

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

rust/src/push/evaluator.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ pub struct PushRuleEvaluator {
8787

8888
/// The related events, indexed by relation type. Flattened in the same manner as
8989
/// `flattened_keys`.
90-
related_events_flattened: BTreeMap<String, BTreeMap<String, String>>,
90+
related_events_flattened: BTreeMap<String, BTreeMap<String, SimpleJsonValue>>,
9191

9292
/// If msc3664, push rules for related events, is enabled.
9393
related_event_match_enabled: bool,
@@ -116,7 +116,7 @@ impl PushRuleEvaluator {
116116
room_member_count: u64,
117117
sender_power_level: Option<i64>,
118118
notification_power_levels: BTreeMap<String, i64>,
119-
related_events_flattened: BTreeMap<String, BTreeMap<String, String>>,
119+
related_events_flattened: BTreeMap<String, BTreeMap<String, SimpleJsonValue>>,
120120
related_event_match_enabled: bool,
121121
room_version_feature_flags: Vec<String>,
122122
msc3931_enabled: bool,
@@ -441,7 +441,7 @@ impl PushRuleEvaluator {
441441
return Ok(false);
442442
};
443443

444-
let haystack = if let Some(haystack) = event.get(&**key) {
444+
let haystack = if let Some(SimpleJsonValue::Str(haystack)) = event.get(&**key) {
445445
haystack
446446
} else {
447447
return Ok(false);

stubs/synapse/synapse_rust/push.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class PushRuleEvaluator:
6262
room_member_count: int,
6363
sender_power_level: Optional[int],
6464
notification_power_levels: Mapping[str, int],
65-
related_events_flattened: Mapping[str, Mapping[str, str]],
65+
related_events_flattened: Mapping[str, Mapping[str, SimpleJsonValue]],
6666
related_event_match_enabled: bool,
6767
room_version_feature_flags: Tuple[str, ...],
6868
msc3931_enabled: bool,

synapse/push/bulk_push_rule_evaluator.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,13 +235,15 @@ async def _get_power_levels_and_sender_level(
235235

236236
return pl_event.content if pl_event else {}, sender_level
237237

238-
async def _related_events(self, event: EventBase) -> Dict[str, Dict[str, str]]:
238+
async def _related_events(
239+
self, event: EventBase
240+
) -> Dict[str, Dict[str, SimpleJsonValue]]:
239241
"""Fetches the related events for 'event'. Sets the im.vector.is_falling_back key if the event is from a fallback relation
240242
241243
Returns:
242244
Mapping of relation type to flattened events.
243245
"""
244-
related_events: Dict[str, Dict[str, str]] = {}
246+
related_events: Dict[str, Dict[str, SimpleJsonValue]] = {}
245247
if self._related_event_match_enabled:
246248
related_event_id = event.content.get("m.relates_to", {}).get("event_id")
247249
relation_type = event.content.get("m.relates_to", {}).get("rel_type")

0 commit comments

Comments
 (0)