Fix requestOpenIdToken response: integer expires_in

lukaslihotzki · lukaslihotzki · commit 2ab40f8bf5b4 · 2021-06-14T19:38:13.000+02:00
`expires_in` must be an integer according to the OpenAPI spec: https://github.com/matrix-org/matrix-doc/blob/master/data/api/client-server/definitions/openid_token.yaml#L32 True division (`/`) returns a float instead (`"expires_in": 3600.0`). Floor division (`//`) returns an integer, so the response is spec compliant. Signed-off-by: Lukas Lihotzki <lukas@lihotzki.de>
diff --git a/changelog.d/10175.bugfix b/changelog.d/10175.bugfix
@@ -0,0 +1 @@
+Return an integer `expires_in` in requestOpenIdToken response.
diff --git a/synapse/rest/client/v2_alpha/openid.py b/synapse/rest/client/v2_alpha/openid.py
@@ -85,7 +85,7 @@ async def on_POST(self, request, user_id):
                 "access_token": token,
                 "token_type": "Bearer",
                 "matrix_server_name": self.server_name,
-                "expires_in": self.EXPIRES_MS / 1000,
+                "expires_in": self.EXPIRES_MS // 1000,
             },
         )
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Return an integer `expires_in` in requestOpenIdToken response.
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ async def on_POST(self, request, user_id):`
`85`	`85`	`"access_token": token,`
`86`	`86`	`"token_type": "Bearer",`
`87`	`87`	`"matrix_server_name": self.server_name,`
`88`		`- "expires_in": self.EXPIRES_MS / 1000,`
	`88`	`+ "expires_in": self.EXPIRES_MS // 1000,`
`89`	`89`	`},`
`90`	`90`	`)`
`91`	`91`