Move flake8 to end. Don't exit script on failure (#7738)

anoadragon453 · web-flow · commit 177b2d0c19e4 · 2020-06-25T17:58:55.000+01:00
diff --git a/changelog.d/7738.misc b/changelog.d/7738.misc
@@ -0,0 +1 @@
+Move `flake8` to the end of `scripts-dev/lint.sh` as it takes the longest and could cause the script to exit early.
diff --git a/scripts-dev/lint.sh b/scripts-dev/lint.sh
@@ -2,8 +2,8 @@
 #
 # Runs linting scripts over the local Synapse checkout
 # isort - sorts import statements
-# flake8 - lints and finds mistakes
 # black - opinionated code formatter
+# flake8 - lints and finds mistakes
 
 set -e
 
@@ -16,6 +16,6 @@ fi
 
 echo "Linting these locations: $files"
 isort -y -rc $files
-flake8 $files
 python3 -m black $files
 ./scripts-dev/config-lint.sh
+flake8 $files

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Move `flake8` to the end of `scripts-dev/lint.sh` as it takes the longest and could cause the script to exit early.