Keep MacaroonInitException logged as exceptions

David Robertson · David Robertson · commit 016fc20f7e91 · 2022-05-18T16:25:41.000+01:00
Seems to be a legit application bug. See #12787.
diff --git a/synapse/handlers/oidc.py b/synapse/handlers/oidc.py
@@ -220,7 +220,7 @@ async def handle_oidc_callback(self, request: SynapseRequest) -> None:
                 session, state
             )
         except (MacaroonInitException, MacaroonDeserializationException, KeyError) as e:
-            logger.warning("Invalid session for OIDC callback: %s", e)
+            logger.exception("Invalid session for OIDC callback")
             self._sso_handler.render_error(request, "invalid_session", str(e))
             return
         except MacaroonInvalidSignatureException as e:

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ async def handle_oidc_callback(self, request: SynapseRequest) -> None:`
`220`	`220`	`session, state`
`221`	`221`	`)`
`222`	`222`	`except (MacaroonInitException, MacaroonDeserializationException, KeyError) as e:`
`223`		`- logger.warning("Invalid session for OIDC callback: %s", e)`
	`223`	`+ logger.exception("Invalid session for OIDC callback")`
`224`	`224`	`self._sso_handler.render_error(request, "invalid_session", str(e))`
`225`	`225`	`return`
`226`	`226`	`except MacaroonInvalidSignatureException as e:`