Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit d423737

Browse files
committed
accessibility: use hr
1 parent b615764 commit d423737

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

res/css/views/settings/_LayoutSwitcher.pcss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ limitations under the License.
8181
}
8282

8383
.mxLayoutSwitcher_LayoutSelector_LayoutRadio_separator {
84+
border-top: 0;
8485
border-bottom: 1px solid var(--cpd-color-border-interactive-secondary);
8586
}
8687
}

src/components/views/settings/LayoutSwitcher.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ function LayoutRadio({ layout, label }: LayoutRadioProps): JSX.Element {
8888
<RadioControl name="layout" value={layout} defaultChecked={currentLayout === layout} />
8989
<span>{label}</span>
9090
</div>
91-
<div role="separator" className="mxLayoutSwitcher_LayoutSelector_LayoutRadio_separator" />
91+
<hr className="mxLayoutSwitcher_LayoutSelector_LayoutRadio_separator" />
9292
<EventTilePreview
9393
message={_t("common|preview_message")}
9494
layout={layout}

test/components/views/settings/__snapshots__/LayoutSwitcher-test.tsx.snap

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,8 @@ exports[`<LayoutSwitcher /> should render 1`] = `
5252
Modern
5353
</span>
5454
</div>
55-
<div
55+
<hr
5656
class="mxLayoutSwitcher_LayoutSelector_LayoutRadio_separator"
57-
role="separator"
5857
/>
5958
<div
6059
class="mxLayoutSwitcher_LayoutSelector_LayoutRadio_EventTilePreview"
@@ -169,9 +168,8 @@ exports[`<LayoutSwitcher /> should render 1`] = `
169168
Message bubbles
170169
</span>
171170
</div>
172-
<div
171+
<hr
173172
class="mxLayoutSwitcher_LayoutSelector_LayoutRadio_separator"
174-
role="separator"
175173
/>
176174
<div
177175
class="mxLayoutSwitcher_LayoutSelector_LayoutRadio_EventTilePreview"
@@ -286,9 +284,8 @@ exports[`<LayoutSwitcher /> should render 1`] = `
286284
IRC (experimental)
287285
</span>
288286
</div>
289-
<div
287+
<hr
290288
class="mxLayoutSwitcher_LayoutSelector_LayoutRadio_separator"
291-
role="separator"
292289
/>
293290
<div
294291
class="mxLayoutSwitcher_LayoutSelector_LayoutRadio_EventTilePreview mx_IRCLayout"

0 commit comments

Comments
 (0)