Lint fixes

Author: akirk

src/components/structures/LoggedInView.tsx

@@ -553,8 +553,6 @@ class LoggedInView extends React.Component<IProps, IState> {
                 PlatformPeg.get()?.navigateForwardBack(false);
                 handled = true;
                 break;
-            case KeyBindingAction.SelectPrevMessage:
-                handled = true;
         }
 
         // Handle labs actions here, as they apply within the same scope

src/components/structures/MessagePanel.tsx

@@ -58,7 +58,6 @@ import { _t } from "../../languageHandler";
 import { getLateEventInfo } from "./grouper/LateEventGrouper";
 import { getKeyBindingsManager } from "../../KeyBindingsManager";
 import { KeyBindingAction } from "../../accessibility/KeyboardShortcuts";
-import { highlightEvent } from "../../utils/EventUtils";
 
 const CONTINUATION_MAX_INTERVAL = 5 * 60 * 1000; // 5 minutes
 const continuedTypes = [EventType.Sticker, EventType.RoomMessage];
@@ -427,43 +426,43 @@ export default class MessagePanel extends React.Component<IProps, IState> {
      */
     public handleScrollKey(ev: React.KeyboardEvent | KeyboardEvent): void {
         const navAction = getKeyBindingsManager().getNavigationAction(ev);
-        switch (navAction) {
-            case KeyBindingAction.SelectPrevMessage:
-            case KeyBindingAction.SelectNextMessage:
-                const events: WrappedEvent[] = this.props.events.map((event) => {
-                    return { event, shouldShow: this.shouldShowEvent(event) };
-                });
-                const currentEventId = this.focusedEventId || this.props.highlightedEventId || events[events.length-1]?.event.getId()!;
-                if ( navAction === KeyBindingAction.SelectPrevMessage ) {
-                    events.reverse();
-                }
-                let previousEventId = null;
-                for (let i = events.length - 1; i >= 0; i--) {
-                    const { event, shouldShow } = events[i];
-                    if (!shouldShow) {
-                        continue;
-                    }
-                    const eventId = event.getId()!;
-                    if ( previousEventId && eventId === currentEventId ) {
-                        console.log('.mx_EventTile[data-event-id="' + previousEventId + '"]');
-
-                        document.querySelector('.mx_EventTile[data-event-id="' + previousEventId + '"]')?.focus();
-                        this.focusedEventId = previousEventId;
-                        ev.preventDefault();
-                        return;
-                    }
-                    previousEventId = eventId;
+        if (navAction === KeyBindingAction.SelectPrevMessage || navAction === KeyBindingAction.SelectNextMessage) {
+            const events: WrappedEvent[] = this.props.events.map((event) => {
+                return { event, shouldShow: this.shouldShowEvent(event) };
+            });
+            const currentEventId =
+                this.focusedEventId ||
+                this.props.highlightedEventId ||
+                (events[events.length - 1] ? events[events.length - 1].event.getId()! : null);
+            if (navAction === KeyBindingAction.SelectPrevMessage) {
+                events.reverse();
+            }
+            let previousEventId = null;
+            for (let i = events.length - 1; i >= 0; i--) {
+                const { event, shouldShow } = events[i];
+                if (!shouldShow) {
+                    continue;
                 }
-                if ( navAction === KeyBindingAction.SelectNextMessage ) {
-                    defaultDispatcher.dispatch(
-                        {
-                            action: Action.FocusSendMessageComposer,
-                            context: TimelineRenderingType.Room,
-                        },
-                        true,
-                     );
+                const eventId = event.getId()!;
+                if (previousEventId && eventId === currentEventId) {
+                    console.log('.mx_EventTile[data-event-id="' + previousEventId + '"]');
+
+                    document.querySelector('.mx_EventTile[data-event-id="' + previousEventId + '"]')?.focus();
+                    this.focusedEventId = previousEventId;
+                    ev.preventDefault();
+                    return;
                 }
-                break;
+                previousEventId = eventId;
+            }
+            if (navAction === KeyBindingAction.SelectNextMessage) {
+                defaultDispatcher.dispatch(
+                    {
+                        action: Action.FocusSendMessageComposer,
+                        context: TimelineRenderingType.Room,
+                    },
+                    true,
+                );
+            }
         }
 
         this.scrollPanel.current?.handleScrollKey(ev);

src/components/views/rooms/EventTile.tsx

@@ -1210,7 +1210,10 @@ export class UnwrappedEventTile extends React.Component<EventTileProps, IState>
                         "ref": this.ref,
                         "className": classes,
                         "aria-live": ariaLive,
-                        "aria-label": this.props.mxEvent.sender.name + '. ' + (this.props.mxEvent.clearEvent || this.props.mxEvent.event).content.body,
+                        "aria-label":
+                            this.props.mxEvent.sender.name +
+                            ". " +
+                            (this.props.mxEvent.clearEvent || this.props.mxEvent.event).content.body,
                         "aria-atomic": true,
                         "data-scroll-tokens": scrollToken,
                         "data-has-reply": !!replyChain,
@@ -1400,7 +1403,10 @@ export class UnwrappedEventTile extends React.Component<EventTileProps, IState>
                         "className": classes,
                         "tabIndex": -1,
                         "aria-live": ariaLive,
-                        "aria-label": this.props.mxEvent.sender.name + '. ' + (this.props.mxEvent.clearEvent || this.props.mxEvent.event).content.body,
+                        "aria-label":
+                            this.props.mxEvent.sender.name +
+                            ". " +
+                            (this.props.mxEvent.clearEvent || this.props.mxEvent.event).content.body,
                         "aria-atomic": "true",
                         "data-scroll-tokens": scrollToken,
                         "data-layout": this.props.layout,

src/components/views/rooms/SendMessageComposer.tsx

@@ -311,7 +311,9 @@ export class SendMessageComposer extends React.Component<ISendMessageComposerPro
         const navAction = getKeyBindingsManager().getNavigationAction(event);
         switch (navAction) {
             case KeyBindingAction.SelectPrevMessage:
-                (document.querySelector('.mx_EventTile_selected')||document.querySelector('.mx_EventTile_last'))?.focus();
+                (
+                    document.querySelector(".mx_EventTile_selected") || document.querySelector(".mx_EventTile_last")
+                )?.focus();
                 event.preventDefault();
                 event.stopPropagation();
                 return;