Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 7d8623d

Browse files
authored
Fix Match system theme toggle (#12719)
* deps: force react-id version * e2e: use checkbox name
1 parent 6ebaf3b commit 7d8623d

File tree

3 files changed

+4
-18
lines changed

3 files changed

+4
-18
lines changed

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@
6565
"@types/seedrandom": "3.0.8",
6666
"oidc-client-ts": "3.0.1",
6767
"jwt-decode": "4.0.0",
68-
"@floating-ui/react": "0.26.11"
68+
"@floating-ui/react": "0.26.11",
69+
"@radix-ui/react-id": "1.1.0"
6970
},
7071
"dependencies": {
7172
"@babel/runtime": "^7.12.5",

playwright/e2e/settings/appearance-user-settings-tab/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class Helpers {
7777
* Return the system theme toggle
7878
*/
7979
getMatchSystemThemeCheckbox() {
80-
return this.getThemePanel().getByRole("checkbox");
80+
return this.getThemePanel().getByRole("checkbox", { name: "Match system theme" });
8181
}
8282

8383
/**

yarn.lock

+1-16
Original file line numberDiff line numberDiff line change
@@ -2109,15 +2109,7 @@
21092109
"@radix-ui/react-label" "2.0.2"
21102110
"@radix-ui/react-primitive" "1.0.3"
21112111

2112-
"@radix-ui/[email protected]":
2113-
version "1.0.1"
2114-
resolved "https://registry.yarnpkg.com/@radix-ui/react-id/-/react-id-1.0.1.tgz#73cdc181f650e4df24f0b6a5b7aa426b912c88c0"
2115-
integrity sha512-tI7sT/kqYp8p96yGWY1OAnLHrqDgzHefRBKQ2YAkBS5ja7QLcZ9Z/uY7bEjPUatf8RomoXM8/1sMj1IJaE5UzQ==
2116-
dependencies:
2117-
"@babel/runtime" "^7.13.10"
2118-
"@radix-ui/react-use-layout-effect" "1.0.1"
2119-
2120-
"@radix-ui/[email protected]":
2112+
"@radix-ui/[email protected]", "@radix-ui/[email protected]":
21212113
version "1.1.0"
21222114
resolved "https://registry.yarnpkg.com/@radix-ui/react-id/-/react-id-1.1.0.tgz#de47339656594ad722eb87f94a6b25f9cffae0ed"
21232115
integrity sha512-EJUrI8yYh7WOjNOqpoJaf1jlFIH2LvtgAl+YcFqNCa+4hj64ZXmPkAKOFs/ukjz3byN6bdb/AVUqHkI8/uWWMA==
@@ -2277,13 +2269,6 @@
22772269
dependencies:
22782270
"@radix-ui/react-use-callback-ref" "1.1.0"
22792271

2280-
"@radix-ui/[email protected]":
2281-
version "1.0.1"
2282-
resolved "https://registry.yarnpkg.com/@radix-ui/react-use-layout-effect/-/react-use-layout-effect-1.0.1.tgz#be8c7bc809b0c8934acf6657b577daf948a75399"
2283-
integrity sha512-v/5RegiJWYdoCvMnITBkNNx6bCj20fiaJnWtRkU18yITptraXjffz5Qbn05uOiQnOvi+dbkznkoaMltz1GnszQ==
2284-
dependencies:
2285-
"@babel/runtime" "^7.13.10"
2286-
22872272
"@radix-ui/[email protected]":
22882273
version "1.1.0"
22892274
resolved "https://registry.yarnpkg.com/@radix-ui/react-use-layout-effect/-/react-use-layout-effect-1.1.0.tgz#3c2c8ce04827b26a39e442ff4888d9212268bd27"

0 commit comments

Comments
 (0)