Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 5cbb748

Browse files
RiotRobott3chguy
andauthored
Upgrade dependencies (#9249)
* [create-pull-request] automated change * Delint * Hold @types/react* back * Pin axe-core until we fix a11y issues Co-authored-by: t3chguy <[email protected]> Co-authored-by: Michael Telatynski <[email protected]>
1 parent d2109de commit 5cbb748

File tree

6 files changed

+1294
-1563
lines changed

6 files changed

+1294
-1563
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@
175175
"@typescript-eslint/parser": "^5.6.0",
176176
"@wojtekmaj/enzyme-adapter-react-17": "^0.6.1",
177177
"allchange": "^1.1.0",
178-
"axe-core": "^4.4.3",
178+
"axe-core": "4.4.3",
179179
"babel-jest": "^26.6.3",
180180
"blob-polyfill": "^6.0.20211015",
181181
"chokidar": "^3.5.1",

src/components/views/auth/LoginWithQR.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,9 @@ export default class LoginWithQR extends React.Component<IProps, IState> {
9696
private async updateMode(mode: Mode) {
9797
this.setState({ phase: Phase.Loading });
9898
if (this.state.rendezvous) {
99-
this.state.rendezvous.onFailure = undefined;
100-
await this.state.rendezvous.cancel(RendezvousFailureReason.UserCancelled);
99+
const rendezvous = this.state.rendezvous;
100+
rendezvous.onFailure = undefined;
101+
await rendezvous.cancel(RendezvousFailureReason.UserCancelled);
101102
this.setState({ rendezvous: undefined });
102103
}
103104
if (mode === Mode.Show) {

src/components/views/elements/ReplyChain.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ export default class ReplyChain extends React.Component<IProps, IState> {
240240
{ _t("In reply to <a>this message</a>",
241241
{},
242242
{ a: (sub) => (
243-
<a className="mx_reply_anchor" href={`#${eventId}`} scroll-to={eventId}> { sub } </a>
243+
<a className="mx_reply_anchor" href={`#${eventId}`} data-scroll-to={eventId}> { sub } </a>
244244
),
245245
})
246246
}

src/components/views/rooms/RoomSublist.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -747,13 +747,12 @@ export default class RoomSublist extends React.Component<IProps, IState> {
747747

748748
public render(): React.ReactElement {
749749
const visibleTiles = this.renderVisibleTiles();
750+
const hidden = !this.state.rooms.length && !this.props.extraTiles?.length && this.props.alwaysVisible !== true;
750751
const classes = classNames({
751752
'mx_RoomSublist': true,
752753
'mx_RoomSublist_hasMenuOpen': !!this.state.contextMenuPosition,
753754
'mx_RoomSublist_minimized': this.props.isMinimized,
754-
'mx_RoomSublist_hidden': (
755-
!this.state.rooms.length && !this.props.extraTiles?.length && this.props.alwaysVisible !== true
756-
),
755+
'mx_RoomSublist_hidden': hidden,
757756
});
758757

759758
let content = null;
@@ -898,6 +897,7 @@ export default class RoomSublist extends React.Component<IProps, IState> {
898897
ref={this.sublistRef}
899898
className={classes}
900899
role="group"
900+
aria-hidden={hidden}
901901
aria-label={this.props.label}
902902
onKeyDown={this.onKeyDown}
903903
>

src/utils/exportUtils/exportJS.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function showToast(text) {
3535
window.onload = () => {
3636
document.querySelectorAll('.mx_reply_anchor').forEach(element => {
3737
element.addEventListener('click', event => {
38-
showToastIfNeeded(event.target.getAttribute("scroll-to"));
38+
showToastIfNeeded(event.target.dataset.scrollTo);
3939
});
4040
});
4141
};

0 commit comments

Comments
 (0)