Revert "Use an improved regex that does not have have to iterate through the

entire string, and can just backtrack at most the last 2 characters."

This regex is very efficient, but requires a specific form of the emoji
shortcode that it is not clear is within our control. This is a restriction
that is not required by the technicalities of solving the bug this PR is
attempting to fix. (It requires that an emoji shortcode end with a colon.)

This reverts commit 220cb0e.

Signed-off-by: Ryan Browne <[email protected]>

Author: Ryan Browne

src/autocomplete/EmojiProvider.tsx

@@ -64,8 +64,10 @@ function score(query, space) {
 }
 
 function colonsTrimmed(str: string): string {
-    // Trim off leading and potentially trailing `:` to correctly match the emoji shortcode names as they exist in emojibase.
-    return str.replace(/^:(.*[^:]):?$/, "$1");
+    // Trim off leading and potentially trailing `:` to correctly match the emoji data as they exist in emojibase.
+    // Notes: The regex is pinned to the start and end of the string so that we can use the lazy-capturing `*?` matcher.
+    // It needs to be lazy so that the trailing `:` is not captured in the replacement group, if it exists.
+    return str.replace(/^:(.*?):?$/, "$1");
 }
 
 export default class EmojiProvider extends AutocompleteProvider {