Tweak sonarqube run (#8475)

Author: t3chguy

.github/workflows/sonarqube.yml

@@ -8,6 +8,7 @@ jobs:
   sonarqube:
     name: SonarQube
     runs-on: ubuntu-latest
+    if: github.event.workflow_run.conclusion == 'success'
     steps:
       - uses: actions/checkout@v2
         with:
@@ -17,7 +18,6 @@ jobs:
       # (https://github.com/actions/download-artifact/issues/60) so instead we get this mess:
       - name: Download Coverage Report
         uses: actions/[email protected]
-        if: github.event.workflow_run.conclusion == 'success'
         with:
           script: |
             const artifacts = await github.actions.listWorkflowRunArtifacts({
@@ -36,9 +36,9 @@ jobs:
             });
             const fs = require('fs');
             fs.writeFileSync('${{github.workspace}}/coverage.zip', Buffer.from(download.data));
+
       - name: Extract Coverage Report
         run: unzip -d coverage coverage.zip && rm coverage.zip
-        if: github.event.workflow_run.conclusion == 'success'
 
       - name: SonarCloud Scan
         uses: SonarSource/sonarcloud-github-action@master

sonar-project.properties

@@ -19,4 +19,3 @@ sonar.typescript.tsconfigPath=./tsconfig.json
 sonar.javascript.lcov.reportPaths=coverage/lcov.info
 sonar.coverage.exclusions=spec/*.ts
 sonar.testExecutionReportPaths=coverage/test-report.xml
-sonar.genericcoverage.unitTestReportPaths=coverage/test-report.xml