Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Commit 1e73184

Browse files
Improve message editing UI (#8483)
* Improve message editing UI Signed-off-by: Šimon Brandner <[email protected]> * Remove weird padding on bubble layout Signed-off-by: Šimon Brandner <[email protected]>
1 parent ab26aad commit 1e73184

File tree

3 files changed

+8
-36
lines changed

3 files changed

+8
-36
lines changed

res/css/views/rooms/_EditMessageComposer.scss

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ limitations under the License.
1616
*/
1717

1818
.mx_EditMessageComposer {
19-
19+
display: flex;
20+
flex-direction: column;
21+
gap: 5px;
2022
padding: 3px;
21-
// this is to try not make the text move but still have some
22-
// padding around and in the editor.
23-
// Actual values from fiddling around in inspector
24-
margin: -7px -10px -5px -10px;
25-
overflow: visible !important; // override mx_EventTile_content
23+
24+
// Make sure the formatting bar is visible
25+
overflow: visible !important; // override mx_EventTile_content
2626

2727
.mx_BasicMessageComposer_input {
2828
border-radius: 4px;
@@ -40,23 +40,10 @@ limitations under the License.
4040
display: flex;
4141
flex-direction: row;
4242
justify-content: flex-end;
43-
padding: 5px;
44-
position: absolute;
45-
left: 0;
46-
background: $header-panel-bg-color;
47-
z-index: 100;
48-
right: 0;
49-
margin: 0 -110px 0 0;
50-
padding-right: 147px;
43+
gap: 5px;
5144

5245
.mx_AccessibleButton {
53-
margin-left: 5px;
5446
padding: 5px 40px;
5547
}
5648
}
5749
}
58-
59-
.mx_EventTile_last .mx_EditMessageComposer_buttons {
60-
position: static;
61-
margin-right: -147px;
62-
}

res/css/views/rooms/_EventBubbleTile.scss

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -423,13 +423,6 @@ limitations under the License.
423423
}
424424
}
425425

426-
.mx_EditMessageComposer_buttons {
427-
position: static;
428-
padding: 0;
429-
margin: 8px 0 0;
430-
background: transparent;
431-
}
432-
433426
.mx_ReactionsRow {
434427
margin-right: -18px;
435428
margin-left: -9px;

res/css/views/rooms/_EventTile.scss

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,6 @@ $threadInfoLineHeight: calc(2 * $font-12px); // See: _commons.scss
121121

122122
&.mx_EventTile_continuation {
123123
padding-top: 0px !important;
124-
125-
&.mx_EventTile_isEditing {
126-
padding-top: 5px !important;
127-
margin-top: -5px;
128-
}
129-
}
130-
131-
&.mx_EventTile_isEditing {
132-
background-color: $header-panel-bg-color;
133124
}
134125

135126
.mx_DisambiguatedProfile {
@@ -177,6 +168,7 @@ $threadInfoLineHeight: calc(2 * $font-12px); // See: _commons.scss
177168
/* this is used for the tile for the event which is selected via the URL.
178169
* TODO: ultimately we probably want some transition on here.
179170
*/
171+
&.mx_EventTile_isEditing > .mx_EventTile_line,
180172
&.mx_EventTile_selected > .mx_EventTile_line {
181173
box-shadow: inset calc(50px + $selected-message-border-width) 0 0 -50px $accent;
182174
background-color: $event-selected-color;

0 commit comments

Comments
 (0)