Pass more args to Sonar (#2356)

* Pass projectVersion to Sonar

* Fix s'more

* Fix sonar.lang.patterns.ts

Author: t3chguy

.github/workflows/sonarqube.yml

@@ -10,9 +10,15 @@ jobs:
     runs-on: ubuntu-latest
     if: github.event.workflow_run.conclusion == 'success'
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
-          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+          ref: ${{ github.event.workflow_run.head_sha }} # checkout commit that triggered this workflow
+          fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
+
+      # fetch develop so that Sonar can identify new issues in PR builds
+      - name: Fetch develop
+        if: "github.event.workflow_run.head_branch != 'develop'"
+        run: git rev-parse HEAD && git fetch origin develop:develop && git status && git rev-parse HEAD
 
       # There's a 'download artifact' action, but it hasn't been updated for the workflow_run action
       # (https://github.com/actions/download-artifact/issues/60) so instead we get this mess:
@@ -40,8 +46,16 @@ jobs:
       - name: Extract Coverage Report
         run: unzip -d coverage coverage.zip && rm coverage.zip
 
+      - name: Read version
+        id: version
+        uses: WyriHaximus/github-action-get-previous-tag@v1
+
       - name: SonarCloud Scan
         uses: SonarSource/sonarcloud-github-action@master
+        with:
+          args: >
+            -Dsonar.projectVersion=${{ steps.version.outputs.tag }}
+            -Dsonar.scm.revision=${{ github.event.workflow_run.head_sha }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

sonar-project.properties

@@ -12,3 +12,5 @@ sonar.typescript.tsconfigPath=./tsconfig.json
 sonar.javascript.lcov.reportPaths=coverage/lcov.info
 sonar.coverage.exclusions=spec/**/*
 sonar.testExecutionReportPaths=coverage/test-report.xml
+
+sonar.lang.patterns.ts=**/*.ts,**/*.tsx