Skip to content

MSC4133: Extending User Profile API with Key:Value Pairs #4133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Jan 31, 2025
Merged

MSC4133: Extending User Profile API with Key:Value Pairs #4133

merged 57 commits into from
Jan 31, 2025

Conversation

tcpipuk
Copy link
Contributor

@tcpipuk tcpipuk commented Apr 19, 2024 •
edited by clokep
Loading

@tcpipuk tcpipuk changed the title MSC0000: Extending User Profile API with Key:Value Pairs MSC4133: Extending User Profile API with Key:Value Pairs Apr 19, 2024
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Apr 19, 2024
tulir
tulir reviewed Apr 19, 2024
View reviewed changes
@turt2live
Copy link
Member

@tcpipuk when you get a chance, please sign off on your changes to allow the MSC to eventually be eligible for acceptance.

@tcpipuk

This comment was marked as resolved.

Sign in to view
@turt2live
Copy link
Member

Looks great, thanks!

@tcpipuk tcpipuk marked this pull request as ready for review April 19, 2024 19:46
@andrewzhurov
Copy link

Seems we discuss here a key-value CRDT, as keys would need to be updated over time. Personally, I'm all in favor.
With no regard be those events a part of a (messaging) Room or be in its own Profile Room (#1769) (which would be neat),
we need a mechanism to get the latest key-value pairs.

Matrix Event Graph is isomorphic to Merkle-CRDT that powers OrbitDB (key-value DB is one of the supported CRDT).
Taking an inspiration from how key-value CRDT works may be of help to spec it for those Servers wishing to opt-in.

@andrewzhurov andrewzhurov mentioned this pull request May 29, 2024
Draft
@tcpipuk tcpipuk mentioned this pull request Jun 7, 2024
Closed
clokep
clokep reviewed Jun 7, 2024
View reviewed changes
richvdh
richvdh reviewed Jan 23, 2025
View reviewed changes
This was referenced Jan 23, 2025
Open
Open
@turt2live
Copy link
Member

The SCT would like to take recent comments into consideration as part of the FCP call for this MSC, and is pausing FCP for the moment while that consideration happens.

Our process is that a concern raised during FCP prevents the FCP from finishing, but our bot doesn't understand that and may say that the FCP is finished over the weekend. If this happens, it's untrue and we'll manually correct the state to be in FCP when we're back at a terminal.

@mscbot concern Feedback during FCP needs consideration.

@mscbot mscbot added the unresolved-concerns This proposal has at least one outstanding concern label Jan 23, 2025
@mscbot

This comment was marked as outdated.

Sign in to view
@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 25, 2025
@richvdh
Copy link
Member

richvdh commented Jan 25, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

No it isn't

@richvdh richvdh added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. disposition-merge and removed finished-final-comment-period labels Jan 25, 2025
@turt2live
Copy link
Member

I'm not sure how the bot will respond to this, but the SCT is resolving the outstanding concern on addressing the recent feedback. Under normal process, this would cause FCP to finish immediately, however it feels valuable for this MSC to have an opportunity for final thoughts to be raised.

FCP will resume until 15:00 UTC on Friday, January 31st, 2025.

@mscbot resolve Feedback during FCP needs consideration.

@mscbot mscbot removed the unresolved-concerns This proposal has at least one outstanding concern label Jan 30, 2025
@turt2live
Copy link
Member

The final comment period, with a disposition to merge, as per the review above, is now complete.

No it isn't

Now it is

@turt2live turt2live added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 31, 2025
@turt2live turt2live merged commit eb813af into matrix-org:main Jan 31, 2025
1 check passed
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jan 31, 2025
@RoootTheFox RoootTheFox mentioned this pull request Feb 4, 2025
Open
@Half-Shot Half-Shot mentioned this pull request Feb 14, 2025
Open
3 tasks
@tulir
Copy link
Member

tulir commented Feb 14, 2025

Spec PR: matrix-org/matrix-spec#2071

@tulir tulir added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Feb 14, 2025
@efMss24 efMss24 mentioned this pull request Mar 13, 2025
Closed
ratkokostov7 pushed a commit to globalid/synapse that referenced this pull request Apr 9, 2025
@clokep @anoadragon453 @ratkokostov
Implement MSC4133 to support custom profile fields. (#17488)
6e3c79b 
Implementation of
[MSC4133](matrix-org/matrix-spec-proposals#4133)
to support custom profile fields. It is behind an experimental flag and
includes tests.


### Pull Request Checklist

<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
  - Use markdown where necessary, mostly for `code blocks`.
  - End with either a period (.) or an exclamation mark (!).
  - Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct
(run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))

---------

Co-authored-by: Andrew Morgan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@uhoreg uhoreg uhoreg left review comments

@clokep clokep clokep left review comments

@cvwright cvwright cvwright left review comments

@girlbossceo girlbossceo girlbossceo left review comments

@Johennes Johennes Johennes left review comments

@turt2live turt2live turt2live approved these changes

@ara4n ara4n ara4n left review comments

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@MTRNord MTRNord MTRNord requested changes

@bkil bkil bkil left review comments

@jimmackenzie jimmackenzie jimmackenzie left review comments

@dbkr dbkr dbkr left review comments

@tulir tulir tulir approved these changes

@kegsay kegsay kegsay left review comments

@erikjohnston erikjohnston erikjohnston left review comments

@TheArcaneBrony TheArcaneBrony TheArcaneBrony left review comments

@deepbluev7 deepbluev7 deepbluev7 left review comments

@Gnuxie Gnuxie Gnuxie left review comments

@pau-ww pau-ww pau-ww left review comments

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal spec-pr-in-review A proposal which has been PR'd against the spec and is in review
Projects
Spec Core Team Backlog
Status: Requires spec PR review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.