-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC2380: Matrix Media Information API #2380
base: old_master
Are you sure you want to change the base?
Conversation
content. Given the content types are optional, clients may not rely on the | ||
information being present anyways. | ||
|
||
This would also be yet another HTTP call that clients would have to perform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if data model in this MSC be aligned with that used in the related msgtypes (m.file
etc.): e.g., the current convention uses w
and h
instead of width
and height
. Alternatively, this MSC could be put into relationship to extensible events (making it a much longer story) because the current convention, admittedly, is suboptimal.
the content repository cannot identify the type, it must return | ||
application/octet-stream. | ||
|
||
The size is just the size in bytes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The size is just the size in bytes. | |
The `size` is just the size in bytes. |
} | ||
``` | ||
|
||
The content repository must attempt to identify the content independently of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably out-of-scope for this MSC but....why do clients specify the content type at all, then? Wouldn't it be better if the server always determines it and adds it to the event, then? That way people receiving the image events could also be sure that the content type is accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like, it might make more sense for the server to replace the "info" blob rather than the client to specify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This recommendation is actually a terrible idea because encrypted attachments are blobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, forgot for a moment encryption exists 👍
|
||
Authored by Travis Ralston (@turt2live) | ||
|
||
Knowing how large a given piece of content actually is before downloading it can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the same thing could be achieved with a HEAD request in the end. You'd lose support for custom metadata, but if you just want to know the size and type it's a good start that reduces the amount of reinvention we need to do.
Rendered
Author: @turt2live
Fixes: https://github.com/matrix-org/matrix-doc/issues/703