Allow the filter JSON to be passed inline in the /sync request #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,12 @@ paths: | |||
| name: filter | |||
| type: string | |||
| description: |- | |||
| The ID of a filter created using the filter API. | |||
| The ID of a filter created using the filter API or a filter JSON | |||
There was a problem hiding this comment.
Should the JSON be URL-encoded? Or something else?
There was a problem hiding this comment.
It should be passed like any other query parameter, encoded as UTF-8 and URL encoded.
There was a problem hiding this comment.
We do very explicitly state that all strings must be UTF-8 encoded in the API Standards section. As far as I know, this is the first place where a query parameter is anything other than a string or an int.
There was a problem hiding this comment.
Is saying that it is passed a string sufficient? c3a1318
This was referenced Dec 8, 2015
|
LGTM |
NegativeMjark
added a commit
that referenced
this pull request
Dec 9, 2015
Allow the filter JSON to be passed inline in the /sync request
NegativeMjark
added a commit
to matrix-org/synapse
that referenced
this pull request
Dec 9, 2015
NegativeMjark
added a commit
to matrix-org/synapse
that referenced
this pull request
Dec 9, 2015
Allow filter JSON object in the filter query parameter in /sync Documented by matrix-org/matrix-spec-proposals#224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.