improve README

Author: martinlindhe

ccdb.go

@@ -25,9 +25,8 @@ func NewFromCCDBCapture(s string) (res Subtitle, err error) {
 			continue
 		}
 		if parseText {
-			// log.Println("TEXT:", row)
 			if row == "\r" || row == "" {
-				parseText = false // XXX until text = empty
+				parseText = false
 			} else {
 				row = strings.TrimSpace(row)
 				if row != "" {
@@ -46,7 +45,6 @@ func NewFromCCDBCapture(s string) (res Subtitle, err error) {
 				}
 				break
 			}
-			// log.Println("TIME:", row)
 			parts := strings.SplitN(row, ",", 2)
 			if len(parts) == 2 {
 				caption.Start, _ = parseCCDBTime(parts[0])

cmd/subber/README.md

@@ -1,4 +1,4 @@
-# About
+## About
 
 Subber is a cli tool for reading,
 writing and manipulating .srt subtitle files
@@ -21,17 +21,19 @@ So, sometimes "other software" needs a cleaned up .srt,
 and the `subber` cli app automates this task.
 
 
-# Installation
+## Installation
 
+Windows and macOS binaries are available under [Releases](https://github.com/martinlindhe/subtitles/releases)
 
+Or if you have golang installed, you can compile from source:
 ```
 go install github.com/martinlindhe/subtitles/cmd/subber
 ```
 
 
-# Usage
+## Usage
 
-To download subtitles for a video file:
+### To download subtitles for a video file
 
 ```
 $ subber movie.mp4
@@ -51,27 +53,37 @@ Some additional flags (use `-h` for full list) includes:
   * `--sync="-3000"` Moves all captions backwards by 3000 ms
 
 
-Remove ads from an existing .srt file:
+### Remove ads from an existing .srt file
 
 ```
 $ subber subtitle.srt
 
 Removing caption 21 [<font color="#FFFF00"> Captions by VITAC  </font><font color="#00FFFF"> www.vitac.com</font>]
 ```
 
-Strip html tags from .srt:
+### Strip html tags from .srt
 
 ```
 $ subber subtitle.srt --filter="html"
 
 [html] <i>And there's a lot of it there.</i> -> And there's a lot of it there.
 ```
 
-Normalize capitalization in .srt:
+### Normalize capitalization in .srt
 
 ```
 $ subber subtitle.srt --filter="caps"
 
 [caps] INTRODUCING -> Introducing
 [caps] right, to go? -> Right, to go?
 ```
+
+### Convert a .ssa to a .srt
+
+```
+$ subber subtitle.ssa -o subtitle.srt
+```
+
+## License
+
+Under [MIT](LICENSE)

cmd/subber/subber.go

@@ -89,7 +89,6 @@ func cleanupSub(data []byte, filterName string, keepAds bool, sync int) (string,
 }
 
 func action(inFileName, outFileName string) error {
-
 	if outFileName == "" {
 		outFileName = inFileName
 	}
@@ -138,7 +137,6 @@ func action(inFileName, outFileName string) error {
 		}
 		return nil
 	}
-	backupSub(subFileName)
 	out, _ = cleanupSub(data, *filterName, *keepAds, *sync)
 	err = writeText(subFileName, *skipBackups, out)
 	if err != nil {
@@ -148,24 +146,13 @@ func action(inFileName, outFileName string) error {
 	return nil
 }
 
-func backupSub(fileName string) {
-	log.Println("XXX TODO impl backupSub")
-}
-
 func writeText(outFileName string, skipBackups bool, text string) error {
-
 	if !skipBackups && fileExists(outFileName) {
 		backupFileName := outFileName + ".org"
 		os.Rename(outFileName, backupFileName)
 		// fmt.Printf("Backed up to %s\n", backupFileName)
 	}
-
-	err := ioutil.WriteFile(outFileName, []byte(text), 0644)
-	if err != nil {
-		return err
-	}
-
-	return nil
+	return ioutil.WriteFile(outFileName, []byte(text), 0644)
 }
 
 func fileExists(name string) bool {