Merge pull request #388 from marp-team/silence-chrome-path-warning-if-used-edge

Prevent outputting a warning about CHROME_PATH if fallbacked to Edge

Author: yhatt

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## [Unreleased]
 
+### Fixed
+
+- Prevent outputting a warning about `CHROME_PATH` env if fallbacked to Edge ([#388](https://github.com/marp-team/marp-cli/pull/388))
+
 ## v1.4.0 - 2021-08-29
 
 ### Added

src/utils/puppeteer.ts

@@ -42,14 +42,16 @@ export const generatePuppeteerLaunchArgs = () => {
 
   // Resolve Chrome path to execute
   if (executablePath === false) {
+    let findChromeError: Error | undefined
+
     if (process.env.IS_DOCKER) {
       // Use already known path within Marp CLI official Docker image
       executablePath = '/usr/bin/chromium-browser'
     } else {
       try {
         executablePath = findChromeInstallation()
       } catch (e) {
-        if (e instanceof Error) warn(e.message)
+        if (e instanceof Error) findChromeError = e
       }
     }
 
@@ -58,6 +60,8 @@ export const generatePuppeteerLaunchArgs = () => {
       executablePath = findEdgeInstallation()
 
       if (!executablePath) {
+        if (findChromeError) warn(findChromeError.message)
+
         error(
           'You have to install Google Chrome, Chromium, or Microsoft Edge to convert slide deck with current options.',
           CLIErrorCode.NOT_FOUND_CHROMIUM