AVRO-3631: Fix clippy and Rat issues

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>

Author: martin-g

lang/rust/avro/src/ser.rs

@@ -17,8 +17,7 @@
 
 //! Logic for serde-compatible serialization.
 use crate::{types::Value, Error};
-use ref_thread_local::ref_thread_local;
-use ref_thread_local::RefThreadLocal;
+use ref_thread_local::{ref_thread_local, RefThreadLocal};
 use serde::{ser, Serialize};
 use std::{collections::HashMap, iter::once};
 
@@ -1097,19 +1096,19 @@ mod tests {
             ),
             (
                 "fixed_field".to_owned(),
-                Value::Fixed(6, Vec::from(test.fixed_field.clone())),
+                Value::Fixed(6, Vec::from(test.fixed_field)),
             ),
             (
                 "fixed_field2".to_owned(),
-                Value::Fixed(2, Vec::from(test.fixed_field2.clone())),
+                Value::Fixed(2, Vec::from(test.fixed_field2)),
             ),
             (
                 "bytes_field".to_owned(),
-                Value::Bytes(Vec::from(test.bytes_field.clone())),
+                Value::Bytes(Vec::from(test.bytes_field)),
             ),
             (
                 "bytes_field2".to_owned(),
-                Value::Bytes(Vec::from(test.bytes_field2.clone())),
+                Value::Bytes(Vec::from(test.bytes_field2)),
             ),
             (
                 "vec_field".to_owned(),

lang/rust/avro/src/types.rs

@@ -2399,11 +2399,14 @@ Field with name '"b"' is not a member of the map items"#,
 
     #[test]
     fn avro_3631_test_serialize_fixed_fields() {
+        use crate::{avro_serialize_bytes, avro_serialize_fixed};
+
         #[derive(Debug, Serialize, Deserialize)]
         struct TestStructFixedField<'a> {
+            #[serde(serialize_with = "avro_serialize_bytes")]
             bytes_field: &'a [u8],
             vec_field: Vec<u8>,
-            #[serde(with = "serde_bytes")]
+            #[serde(serialize_with = "avro_serialize_fixed")]
             fixed_field: [u8; 6],
             // #[serde(with = "serde_bytes")]
             // #[serde(with = "serde_bytes")]

lang/rust/avro/tests/ser.rs

@@ -1,5 +1,21 @@
-use apache_avro::to_value;
-use apache_avro::types::Value;
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use apache_avro::{to_value, types::Value};
 use serde::{Deserialize, Serialize};
 
 #[test]
@@ -25,11 +41,11 @@ fn avro_3631_visibility_of_avro_serialize_bytes_type() {
     let expected = Value::Record(vec![
         (
             "bytes_field".to_owned(),
-            Value::Bytes(Vec::from(test.bytes_field.clone())),
+            Value::Bytes(Vec::from(test.bytes_field)),
         ),
         (
             "fixed_field".to_owned(),
-            Value::Fixed(6, Vec::from(test.fixed_field.clone())),
+            Value::Fixed(6, Vec::from(test.fixed_field)),
         ),
     ]);