Merge a9f45c9 into 2531376

Author: sanikolaev

.github/workflows/clt_nightly.yml

@@ -1,5 +1,5 @@
 name: Nightly tests
-run-name: Nightly tests ${{ github.sha }}
+run-name: 🌙 Nightly tests ${{ github.sha }}
 
 on:
   schedule:

.github/workflows/nightly_dumps.yml

@@ -1,5 +1,5 @@
 name: Nightly testing of supported versions of mysqldump and elasticdump
-run-name: Nightly tests of mysqldump and elasticdump ${{ github.sha }}
+run-name: 🌙 Nightly tests of mysqldump and elasticdump ${{ github.sha }}
 
 on:
   schedule:

.github/workflows/nightly_memleaks.yml

@@ -0,0 +1,54 @@
+name: Nightly memleaks tests
+run-name: 🌙 Nightly memleaks tests ${{ github.sha }}
+
+on:
+  schedule:
+    - cron: '00 20 * * *'
+  push:
+    paths:
+      - '.github/workflows/nightly_memleaks.yml'    
+  
+# cancels the previous workflow run when a new one appears in the same branch (e.g. master or a PR's branch)
+concurrency:
+  group: nightly_memleaks_${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  memleaks:
+    name: Memleak tests
+    runs-on: ubuntu-22.04
+    defaults:
+      run:
+        shell: bash
+    timeout-minutes: 300
+    container:
+      image: manticoresearch/manticore_valgrind:jammy
+      env:
+        DIAGNOSTIC: 1
+        VERBOSE: 1
+        CTEST_CONFIGURATION_TYPE: "RelWithDebInfo"
+        UNITY_BUILD: 1
+        CACHEB: "../cache"
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v3
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          set-safe-directory: true
+      - name: Check out cache before building
+        uses: actions/cache/[email protected]
+        with:
+          path: cache
+          key: build_linux_debug_x86_64
+      - name: memcheck.sh
+        run: |
+          mysqld &
+          bash memcheck.sh
+      - name: Upload build artifacts
+        if: always()
+        continue-on-error: true
+        uses: manticoresoftware/upload_artifact_with_retries@v4
+        with:
+          name: memleaks_${{ github.sha }}
+          path: build/Testing
+  

cmake/GetVCPKG.cmake

@@ -36,11 +36,11 @@ prepend_prefix ( ${_VCACHE} )
 unset ( vcpkg_params )
 if (CMAKE_CROSSCOMPILING)
 	set ( vcpkg_params "--triplet=${_VCARCH}-${_TARGET}" )
+	set ( ENV{VCPKG_OVERLAY_TRIPLETS} "${MANTICORE_SOURCE_DIR}/dist/build_dockers/cross/triplets" )
 endif()
 
 set ( ENV{MANTICORE_SOURCE_DIR} "${MANTICORE_SOURCE_DIR}" )
 set ( ENV{VCPKG_DEFAULT_BINARY_CACHE} "${CACHEB}/vcpkg" )
-set ( ENV{VCPKG_OVERLAY_TRIPLETS} "${MANTICORE_SOURCE_DIR}/dist/build_dockers/cross/triplets" )
 
 if (NOT EXISTS ENV{VCPKG_DEFAULT_BINARY_CACHE})
 	file ( MAKE_DIRECTORY "$ENV{VCPKG_DEFAULT_BINARY_CACHE}" )

memcheck.sh

@@ -0,0 +1,63 @@
+#!/bin/bash
+# Run memcheck.
+# This script can be run on the host, or in the docker
+
+chmod +x valgrind
+mkdir -p build
+cd build
+
+[[ -z "${CACHEB}" ]] && export CACHEB=../cache
+[[ ! -e "${CACHEB}" ]] && mkdir -p ${CACHEB}
+[[ -z "${uid}" ]] && export uid=`id -u`
+[[ -z "${gid}" ]] && export gid=`id -g`
+trap "chown -R $uid:$gid ." EXIT
+
+export CTEST_CONFIGURATION_TYPE=RelWithDebInfo
+export CTEST_CMAKE_GENERATOR=Ninja
+export XTRA_FLAGS="CMAKE_C_COMPILER=/usr/bin/clang-16;CMAKE_CXX_COMPILER=/usr/bin/clang++-16"
+
+export NO_TESTS=1
+time ctest -VV -S ../misc/ctest/memcheck.cmake
+src/searchd --mockstack | tail -n +6 > stack.txt
+
+source stack.txt
+#export MEMORYCHECK_COMMAND_OPTIONS='--tool=memcheck --leak-check=full --track-origins=yes --time-stamp=yes'
+export MANTICORE_THREADS_EX='2/1+2/1'
+export NO_TESTS=0
+rm -f Testing/Temporary/MemoryChecker.*.log
+time ctest -V -S ../misc/ctest/memcheck.cmake
+find Testing/Temporary/MemoryChecker.*.log -size 0 -delete
+
+# Analysis of memory leak reports
+echo "Analyzing memory leak reports..."
+LEAK_FOUND=0
+LEAK_PATTERNS=(definitely invalid uninitialized)
+
+# Function to check for memory leaks in a file
+check_leaks() {
+    local file=$1
+    local test_num=$(basename "$file" | sed -E 's/MemoryChecker\.([0-9]+)\.log/\1/')
+    
+    for pattern in "${LEAK_PATTERNS[@]}"; do
+        if grep -i "$pattern" "$file" > /dev/null; then
+            echo "$pattern DETECTED in test_$test_num"
+            cat "$file"
+            LEAK_FOUND=1
+        fi
+    done
+}
+
+# Process all memory checker log files
+for log_file in Testing/Temporary/MemoryChecker.*.log; do
+    if [ -f "$log_file" ]; then
+        check_leaks "$log_file"
+    fi
+done
+
+if [ $LEAK_FOUND -eq 1 ]; then
+    echo "Memory leaks were detected. Check the logs above for details."
+    exit 1
+else
+    echo "No memory leaks detected."
+    exit 0
+fi

memdocker.sh

@@ -0,0 +1,18 @@
+#!/bin/bash
+#Run shell in valgrind docker
+
+# Use environment variable BUILD_DOCKER if set, otherwise use default value
+BUILD_DOCKER=${BUILD_DOCKER:-manticoresearch/manticore_valgrind:jammy}
+CONFIG=RelWithDebInfo
+WORKDIR=/work
+
+docker run --rm -it \
+-v $(pwd):$WORKDIR \
+-e uid=`id -u` \
+-e gid=`id -g` \
+-e DIAGNOSTIC=1 \
+-e VERBOSE=1 \
+-e CACHEB=$CACHEB \
+-e CTEST_CONFIGURATION_TYPE=$CONFIG \
+-e UNITY_BUILD=1 \
+$BUILD_DOCKER /bin/bash

misc/ctest/memcheck.cmake

@@ -8,6 +8,8 @@ set ( LIBS_BUNDLE "$ENV{LIBS_BUNDLE}" )
 set ( CTEST_REGEX "$ENV{CTEST_REGEX}" )
 set ( SEARCHD_CLI_EXTRA "$ENV{SEARCHD_CLI_EXTRA}" )
 set ( XTRA_FLAGS "$ENV{XTRA_FLAGS}" )
+set ( NO_TESTS "$ENV{NO_TESTS}" )
+set ( UNITY_BUILD "$ENV{UNITY_BUILD}" )
 set_property ( GLOBAL PROPERTY Label P$ENV{CI_PIPELINE_ID} J$ENV{CI_JOB_ID} )
 
 if (NOT CTEST_CMAKE_GENERATOR)
@@ -25,7 +27,10 @@ endif ()
 # just reference line for manual configuration
 # cmake -GNinja -DCMAKE_BUILD_TYPE=RelWithDebInfo -DWITH_ODBC=1 -DWITH_RE2=1 -DWITH_STEMMER=1 -DWITH_POSTGRESQL=0 -DWITH_EXPAT=1 -DWITH_SSL=1 -DTEST_SPECIAL_EXTERNAL=1 -DDISABLE_MEMROUTINES=1 -DCMAKE_C_COMPILER=/usr/bin/clang-12 -DCMAKE_CXX_COMPILER=/usr/bin/clang++-12 ..
 # common test options
-set ( CONFIG_OPTIONS "WITH_ODBC=1;WITH_RE2=1;WITH_STEMMER=1;WITH_POSTGRESQL=0;WITH_EXPAT=1;WITH_SSL=1;TEST_SPECIAL_EXTERNAL=1;DISABLE_MEMROUTINES=1" )
+set ( CONFIG_OPTIONS "WITH_ODBC=1;WITH_RE2=1;WITH_STEMMER=1;WITH_POSTGRESQL=0;WITH_EXPAT=1;WITH_SSL=1;TEST_SPECIAL_EXTERNAL=1;DISABLE_MEMROUTINES=1;DISABLE_PERFETTO=1" )
+if (UNITY_BUILD)
+	LIST ( APPEND CONFIG_OPTIONS "CMAKE_UNITY_BUILD=${UNITY_BUILD}" )
+endif ()
 set ( CTEST_BINARY_DIRECTORY "${CTEST_SOURCE_DIRECTORY}/build" )
 
 if ( LIBS_BUNDLE )
@@ -68,15 +73,12 @@ set ( CTEST_CUSTOM_WARNING_EXCEPTION ".*flexsphinx.*" )
 
 # Do the test suite
 ctest_start ( "Continuous" )
-ctest_update ()
 ctest_configure ()
 ctest_build ()
 
-if ( CTEST_REGEX )
-#	ctest_test ( RETURN_VALUE retcode INCLUDE "${CTEST_REGEX}" REPEAT UNTIL_PASS:${RETRIES})
-else()
-#	ctest_test ( RETURN_VALUE retcode REPEAT UNTIL_PASS:${RETRIES})
-endif()
+if (NO_TESTS)
+	return ()
+endif ()
 
 if ( WITH_MEMCHECK AND CTEST_MEMORYCHECK_COMMAND )
 	set (ENV{vlg} "${CTEST_MEMORYCHECK_COMMAND}")
@@ -93,8 +95,6 @@ if ( WITH_MEMCHECK AND CTEST_MEMORYCHECK_COMMAND )
 	endif ()
 endif ( WITH_MEMCHECK AND CTEST_MEMORYCHECK_COMMAND )
 
-ctest_submit ()
-
 if ( retcode )
 	MESSAGE ( STATUS "tests failed with ${retcode} code, but we don't fail as it is memcheck pass" )
 endif ()