Merge pull request #2518 from mandiant/bn/skip-test

mr-tz · web-flow · commit e1c786466a64 · 2024-12-03T14:05:24.000+01:00
skip test where BN misses the function
diff --git a/tests/test_binja_features.py b/tests/test_binja_features.py
@@ -40,6 +40,10 @@
     indirect=["sample", "scope"],
 )
 def test_binja_features(sample, scope, feature, expected):
+    # TODO(mr-tz): BinaryNinja does not recognize this function
+    # https://github.com/mandiant/capa/issues/2507
+    if scope.__name__ == "function=0x14004B4F0":
+        pytest.xfail("BinaryNinja does not recognize this function")
     fixtures.do_test_feature_presence(fixtures.get_binja_extractor, sample, scope, feature, expected)
 
 

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,10 @@`
`40`	`40`	`indirect=["sample", "scope"],`
`41`	`41`	`)`
`42`	`42`	`def test_binja_features(sample, scope, feature, expected):`
	`43`	`+ # TODO(mr-tz): BinaryNinja does not recognize this function`
	`44`	`+ # https://github.com/mandiant/capa/issues/2507`
	`45`	`+ if scope.__name__ == "function=0x14004B4F0":`
	`46`	`+ pytest.xfail("BinaryNinja does not recognize this function")`
`43`	`47`	`fixtures.do_test_feature_presence(fixtures.get_binja_extractor, sample, scope, feature, expected)`
`44`	`48`
`45`	`49`