Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "fix broken hashes" automation #1270

Open
Ana06 opened this issue Feb 6, 2025 · 10 comments
Open

Add "fix broken hashes" automation #1270

Ana06 opened this issue Feb 6, 2025 · 10 comments
Assignees
Labels
💎 enhancement It is working, but it could be better 🏃 CI Related to CI

Comments

@Ana06
Copy link
Member

Ana06 commented Feb 6, 2025

Details

Add automation to automatically update the hash of broken packages, similar to the package update. This automation should only be triggered manually and we should add to the PR description that the update needs to be reviewed.

@Ana06 Ana06 added the 🏃 CI Related to CI label Feb 6, 2025
@Ana06 Ana06 added this to the FLARE-VM 2025 Q2-P1 milestone Feb 6, 2025
@PrajeetGuha
Copy link
Collaborator

PrajeetGuha commented Feb 19, 2025

Requesting for more information regarding the issue.

@Ana06
Copy link
Member Author

Ana06 commented Mar 3, 2025

This issue is about extending our current CI to update broken package automatically, similarly as we do with package updates at the moment. What exactly is not clear @PrajeetGuha?

@PrajeetGuha
Copy link
Collaborator

The CI automation automatically updates package url, version and respective hash. By the term hash of broken packages you mean
Packages that uses dynamic links and due to changes in the file in the link, hash does not match?
or something else that I am missing?

@PrajeetGuha
Copy link
Collaborator

Is it same as this? #91

@nasirhm
Copy link

nasirhm commented Mar 15, 2025

Hey @PrajeetGuha, are you working on it ? I can help out with it.

cc: @Ana06

@PrajeetGuha
Copy link
Collaborator

@nasirhm I have not started working on it. You can work on it if you want to.

@nasirhm
Copy link

nasirhm commented Mar 15, 2025

@Ana06 I would like to work on it.

@Ana06
Copy link
Member Author

Ana06 commented Apr 1, 2025

@PrajeetGuha we have some URLs that do not include the version. When a tool update happens, the URL stays the same, but the hash changes. This breaks the package as the hash verification fails. This issue is about adding a new automation (or extending the current one) to update the hash when it does not match the current one. You are right it is a duplicate of #91.

@Ana06
Copy link
Member Author

Ana06 commented Apr 1, 2025

@nasirhm note that this issue requires some knowledge of GitHub Actions, Python, PowerShell and how the project works and is structured. So it may not be the easiest issue to start contributing to the project. But if it is something you find interesting and you want to give it a try, please go for it! Let us know if you plan to work on it, so that otherwise @PrajeetGuha or @sara-rn can work on it.

And sorry for the late reply, I have missed this. 😅

@Ana06 Ana06 added the 💎 enhancement It is working, but it could be better label Apr 1, 2025
@Ana06 Ana06 changed the title Add update broken hash automation Add "fix broken hashes" automation Apr 1, 2025
@Ana06
Copy link
Member Author

Ana06 commented Apr 7, 2025

@nasirhm can you please let us know if you are planing to work on this so that otherwise someone else can start working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better 🏃 CI Related to CI
Projects
None yet
Development

No branches or pull requests

4 participants