Move ESLint and Prettier scripts to the top-level (#117)

Author: jtpio

packages/common/.eslintignore renamed to .eslintignore

@@ -3,4 +3,5 @@ dist
 coverage
 **/*.d.ts
 package.json
-**/__tests__/
+**/__tests__/
+lib

.eslintrc.js

@@ -2,4 +2,4 @@ const eslintBase = require('./eslint-base');
 
 // eslintBase.parserOptions.project = 'tsconfig-base.json';
 
-module.exports = eslintBase;
+module.exports = eslintBase;

.lintstagedrc

@@ -0,0 +1,7 @@
+{
+  "packages/**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}": [
+    "prettier --write",
+    "git add"
+  ]
+}
+

.prettierignore

@@ -0,0 +1,6 @@
+node_modules
+**/node_modules
+**/lib
+**/build
+**/static
+mamba_gator/navigator

packages/common/.prettierrc renamed to .prettierrc

@@ -1 +1,33 @@
-{"data":{"layout-restorer:data":{"main":{"dock":{"type":"tab-area","currentIndex":1,"widgets":["conda-env:conda-env"]},"mode":"multiple-document","current":"conda-env:conda-env"},"left":{"collapsed":true,"widgets":["filebrowser","running-sessions","command-palette","jp-property-inspector","tab-manager","extensionmanager.main-view"]},"right":{"collapsed":true,"widgets":[]}},"jupyterlab-tour:state":{"tutorialsDone":["jupyterlab-tour:welcome"],"version":"2.1.1"},"conda-env:conda-env":{"data":{}}},"metadata":{"id":"/lab"}}
+{
+  "data": {
+    "layout-restorer:data": {
+      "main": {
+        "dock": {
+          "type": "tab-area",
+          "currentIndex": 1,
+          "widgets": ["conda-env:conda-env"]
+        },
+        "mode": "multiple-document",
+        "current": "conda-env:conda-env"
+      },
+      "left": {
+        "collapsed": true,
+        "widgets": [
+          "filebrowser",
+          "running-sessions",
+          "command-palette",
+          "jp-property-inspector",
+          "tab-manager",
+          "extensionmanager.main-view"
+        ]
+      },
+      "right": { "collapsed": true, "widgets": [] }
+    },
+    "jupyterlab-tour:state": {
+      "tutorialsDone": ["jupyterlab-tour:welcome"],
+      "version": "2.1.1"
+    },
+    "conda-env:conda-env": { "data": {} }
+  },
+  "metadata": { "id": "/lab" }
+}

binder/workspace.json

@@ -1,39 +1,39 @@
 module.exports = {
   extends: [
-    "eslint:recommended",
-    "plugin:@typescript-eslint/eslint-recommended",
-    "plugin:@typescript-eslint/recommended",
-    "plugin:prettier/recommended",
-    "plugin:react/recommended"
+    'eslint:recommended',
+    'plugin:@typescript-eslint/eslint-recommended',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:prettier/recommended',
+    'plugin:react/recommended'
   ],
-  parser: "@typescript-eslint/parser",
+  parser: '@typescript-eslint/parser',
   parserOptions: {
-    project: "tsconfig.json",
-    sourceType: "module"
+    project: 'tsconfig.eslint.json',
+    sourceType: 'module'
   },
-  plugins: ["@typescript-eslint"],
+  plugins: ['@typescript-eslint'],
   rules: {
-    "@typescript-eslint/camelcase": "off",
-    "@typescript-eslint/interface-name-prefix": [
-      "error",
-      { prefixWithI: "always" }
+    '@typescript-eslint/camelcase': 'off',
+    '@typescript-eslint/interface-name-prefix': [
+      'error',
+      { prefixWithI: 'always' }
     ],
-    "@typescript-eslint/no-explicit-any": "off",
-    "@typescript-eslint/no-namespace": "off",
-    "@typescript-eslint/no-unused-vars": ["warn", { args: "none" }],
-    "@typescript-eslint/no-use-before-define": "off",
-    "@typescript-eslint/quotes": [
-      "error",
-      "single",
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-namespace': 'off',
+    '@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
+    '@typescript-eslint/no-use-before-define': 'off',
+    '@typescript-eslint/quotes': [
+      'error',
+      'single',
       { avoidEscape: true, allowTemplateLiterals: false }
     ],
-    curly: ["error", "all"],
-    eqeqeq: "error",
-    "prefer-arrow-callback": "error"
+    curly: ['error', 'all'],
+    eqeqeq: 'error',
+    'prefer-arrow-callback': 'error'
   },
   settings: {
     react: {
-      version: "detect"
+      version: 'detect'
     }
   }
 };

eslint-base.js

@@ -13,9 +13,11 @@
     "build": "lerna run build",
     "build:dev": "lerna run build:dev",
     "clean": "lerna run clean",
-    "eslint": "lerna run eslint",
-    "eslint:check": "lerna run eslint:check",
+    "eslint": "eslint . --fix --ext .ts,.tsx",
+    "eslint:check": "eslint . --ext .ts,.tsx",
     "install": "lerna bootstrap",
+    "prettier": "npx prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
+    "prettier:check": "npx prettier --list-different \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
     "publish": "yarn run clean && yarn run build && lerna publish",
     "test": "yarn run eslint:check && lerna run test && yarn run lint && coverage run -m pytest mamba_gator && coverage report",
     "lint": "flake8 setup.py mamba_gator"

package.json

@@ -29,11 +29,8 @@
     "build": "tsc --project .",
     "build:dev": "yarn run build",
     "clean": "rimraf lib tsconfig.tsbuildinfo",
-    "eslint": "eslint . --fix --ext .ts,.tsx",
-    "eslint:check": "eslint . --ext .ts,.tsx",
     "lab:link": "jupyter labextension link . --no-build",
     "prepare": "yarn run clean && yarn run build",
-    "prettier": "npx prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
     "test": "jest --coverage",
     "watch": "tsc -w"
   },

packages/common/.eslintrc.js

@@ -1 +1 @@
-module.exports = require("@jupyterlab/testutils/lib/babel.config");
+module.exports = require('@jupyterlab/testutils/lib/babel.config');

packages/common/.lintstagedrc

@@ -1,4 +1,4 @@
-const jestJupyterLab = require("@jupyterlab/testutils/lib/jest-config");
+const jestJupyterLab = require('@jupyterlab/testutils/lib/jest-config');
 
 const jlabConfig = jestJupyterLab(__dirname);
 
@@ -21,14 +21,14 @@ module.exports = {
   testPathIgnorePatterns,
   transform,
   automock: false,
-  collectCoverageFrom: ["src/**.{ts,tsx}", "!src/*.d.ts"],
-  coverageDirectory: "coverage",
-  coverageReporters: ["lcov", "text"],
+  collectCoverageFrom: ['src/**.{ts,tsx}', '!src/*.d.ts'],
+  coverageDirectory: 'coverage',
+  coverageReporters: ['lcov', 'text'],
   globals: {
-    "ts-jest": {
-      tsConfig: "tsconfig.json"
+    'ts-jest': {
+      tsConfig: 'tsconfig.json'
     }
   },
-  testRegex: "src/.*/.*.spec.ts[x]?$",
-  transformIgnorePatterns: ["/node_modules/(?!(@jupyterlab/.*)/)"]
+  testRegex: 'src/.*/.*.spec.ts[x]?$',
+  transformIgnorePatterns: ['/node_modules/(?!(@jupyterlab/.*)/)']
 };

packages/common/package.json

@@ -32,11 +32,8 @@
     "build": "jlpm run clean && mkdirp ../../mamba_gator/labextension && cd ../../mamba_gator/labextension && npm pack ../../packages/labextension",
     "clean:dev": "rimraf lib tsconfig.tsbuildinfo",
     "clean": "jlpm run clean:dev && rimraf ../../mamba_gator/labextension",
-    "eslint": "eslint . --fix --ext .ts,.tsx",
-    "eslint:check": "eslint . --ext .ts,.tsx",
     "lab:link": "jupyter labextension link . --no-build",
     "prepare": "jlpm run clean:dev && jlpm run build:dev",
-    "prettier": "npx prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
     "test": "",
     "watch": "tsc -w"
   },

packages/labextension/.eslintignore

@@ -20,10 +20,6 @@
     "build:dev": "tsc && webpack -d",
     "clean": "rimraf lib tsconfig.tsbuildinfo ../../mamba_gator/navigator/static/*.* ../../mamba_gator/nbextension/static/*.*",
     "prepublishOnly": "yarn run build",
-    "prettier": "prettier --write '**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}'",
-    "prettier:check": "prettier --list-different \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
-    "eslint": "eslint . --ext .ts,.tsx --fix",
-    "eslint:check": "eslint . --ext .ts,.tsx",
     "test": "",
     "watch:ts": "tsc -w --listEmittedFiles",
     "watch:webpack": "webpack --watch",

packages/labextension/.eslintrc.js

@@ -0,0 +1,4 @@
+{
+  "extends": "./tsconfig-base",
+  "include": ["packages/**/*"]
+}