-
-
Notifications
You must be signed in to change notification settings - Fork 69
Support streams #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hopefully a status code for a stream will be added. Edit: This will not be happening. |
The rendering functions should already work well with partial content, maybe only passing parts of content can be the default mode, updating the Page each time? The only state that would need to be passed each call would be whether it's in a preformatted mode or not, which could be added to Page or something. |
Edit: The first part of this is completed. |
As of 7fe78f4 there is now a configurable download timeout on pages. This would need to be disabled for streams. |
There could be a render and page display pipeline that implements |
|
The default 2 MiB page limit can be upped or page limits can be removed entirely once this is implemented. Edit: Maybe just upped instead of removed, so that infinite or gigantic pages don't take up too much memory |
Once this feature is added the info bar (#142) code will have to be modified so that the total page lines and page percentage changes on the fly. |
What is described in #182 is closely related to this. |
There should be a line-based parser that implements The parser will also have a links channel (buffered), which the tab can pull from to fill the |
This happening on the |
Look into #57 once this is done and see if it can be closed too. |
Moving this to v1.10.0. It has been slowing down the release of v1.9.0 for much too long. There are more important updates that are already in master but are unreleased, or still need to be added. This would be great to have but is not really important from a user's point of view. |
I am closing all stale non-bug issues so this issue will be closed. A PR for this is unlikely to be accepted since Amfora is in maintenance mode and this would be a major change. Goodbye streams, we hardly knew ye. |
An example page with a stream URL is
gemini://chat.mozz.us
, with the actual stream atgemini://chat.mozz.us/stream
.Even for plaintext streams like the one above, this would require a major architectural change, since
Page
s are designed to hold their entire content in a string.A work around could be a stream mode, which might be hard/annoying to get the user to choose though. Could be a shortcut, so they select a link and then press Ctrl-S, or maybe it could be dynamically determined once content reaches a certain length, or the connection doesn't close?Edit: I no longer consider stream mode to be a viable solution. Large non-stream pages would also benefit from Amfora moving to a stream-based architecture.
The text was updated successfully, but these errors were encountered: