Do followLink in a new goroutine, update its doc [#281]

Author: awfulcooking

display/display.go

@@ -241,7 +241,7 @@ func Init(version, commit, builtBy string) {
 			}
 			if i <= len(tabs[tab].page.Links) && i > 0 {
 				// It's a valid link number
-				followLink(tabs[tab], tabs[tab].page.URL, tabs[tab].page.Links[i-1])
+				go followLink(tabs[tab], tabs[tab].page.URL, tabs[tab].page.Links[i-1])
 				return
 			}
 			// Invalid link number, don't do anything

display/private.go

@@ -1,5 +1,8 @@
 package display
 
+// This file contains the functions that aren't part of the public API.
+// The funcs are for network and displaying.
+
 import (
 	"net/url"
 	"strconv"
@@ -9,17 +12,20 @@ import (
 	"github.com/makeworld-the-better-one/amfora/structs"
 )
 
-// This file contains the functions that aren't part of the public API.
-// The funcs are for network and displaying.
-
-// followLink should be used when the user "clicks" a link on a page.
-// Not when a URL is opened on a new tab for the first time.
-// It will handle setting the bottomBar.
+// followLink should be used when the user "clicks" a link on a page,
+// but not when a URL is opened on a new tab for the first time.
+//
+// It will handle updating the bottomBar.
+//
+// It should be called with the `go` keyword to spawn a new goroutine if
+// it would otherwise block the UI loop, such as when called from an input
+// handler.
+// 
+// It blocks until navigation is finished, and we've completed any user
+// interaction related to loading the URL (such as info, error modals)
 func followLink(t *tab, prev, next string) {
 	if strings.HasPrefix(next, "about:") {
-		if final, ok := handleAbout(t, next); ok {
-			t.addToHistory(final)
-		}
+		goURL(t, next)
 		return
 	}
 
@@ -29,7 +35,7 @@ func followLink(t *tab, prev, next string) {
 			Error("URL Error", err.Error())
 			return
 		}
-		go goURL(t, nextURL)
+		goURL(t, nextURL)
 		return
 	}
 	// No content on current tab, so the "prev" URL is not valid.
@@ -39,7 +45,7 @@ func followLink(t *tab, prev, next string) {
 		Error("URL Error", "Link URL could not be parsed")
 		return
 	}
-	go goURL(t, next)
+	goURL(t, next)
 }
 
 // reformatPage will take the raw page content and reformat it according to the current terminal dimensions.

display/tab.go

@@ -86,7 +86,7 @@ func makeNewTab() *tab {
 			linkN, _ := strconv.Atoi(currentSelection[0])
 			tabs[tab].page.Selected = tabs[tab].page.Links[linkN]
 			tabs[tab].page.SelectedID = currentSelection[0]
-			followLink(tabs[tab], tabs[tab].page.URL, tabs[tab].page.Links[linkN])
+			go followLink(tabs[tab], tabs[tab].page.URL, tabs[tab].page.Links[linkN])
 			return
 		}
 		if len(currentSelection) == 0 && (key == tcell.KeyEnter || key == tcell.KeyTab) {
@@ -209,7 +209,7 @@ func makeNewTab() *tab {
 		if cmd >= config.CmdLink1 && cmd <= config.CmdLink0 {
 			if int(cmd) <= len(t.page.Links) {
 				// It's a valid link number
-				followLink(&t, t.page.URL, t.page.Links[cmd-1])
+				go followLink(&t, t.page.URL, t.page.Links[cmd-1])
 				return nil
 			}
 		}