[feature] migrate images to ghcr (kubeflow#2455)

* migrate

Signed-off-by: mahdikhashan <[email protected]>

* update path

Signed-off-by: mahdikhashan <[email protected]>

* pull manifest from ghcr

Signed-off-by: mahdikhashan <[email protected]>

* pull image from ghcr

Signed-off-by: mahdikhashan <[email protected]>

* add dockerhub publish as a job

Signed-off-by: mahdikhashan <[email protected]>

* update images and runner

Signed-off-by: mahdikhashan <[email protected]>

* revert: manifest changes

Signed-off-by: mahdikhashan <[email protected]>

---------

Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: Mahdi Khashan <[email protected]>

Author: mahdikhashan

.github/workflows/build-and-push-images.yaml

@@ -5,8 +5,8 @@ on:
   - pull_request
 
 jobs:
-  build-and-publish:
-    name: Build and Publish Images
+  build-and-publish-to-ghcr:
+    name: Build and Publish Images to Github Container Registry
     runs-on:
       labels: ubuntu-latest-16-cores
 
@@ -31,25 +31,26 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Docker Login
+      - name: GHCR Login
         # Trigger workflow only for kubeflow/trainer repository with specific branch (master, release-*) or tag (v.*).
         if: >-
           github.repository == 'kubeflow/trainer' &&
           (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-') || startsWith(github.ref, 'refs/tags/v'))
         uses: docker/login-action@v3
         with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Publish Component ${{ matrix.component-name }}
+      - name: Publish Component ${{ matrix.component-name }} to GHCR
         # Trigger workflow only for kubeflow/trainer repository with specific branch (master, release-*) or tag (v.*).
         if: >-
           github.repository == 'kubeflow/trainer' &&
           (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-') || startsWith(github.ref, 'refs/tags/v'))
         id: publish
         uses: ./.github/workflows/template-publish-image
         with:
-          image: docker.io/kubeflow/${{ matrix.component-name }}
+          image: ghcr.io/kubeflow/trainer/${{ matrix.component-name }}
           dockerfile: ${{ matrix.dockerfile }}
           platforms: ${{ matrix.platforms }}
           context: ${{ matrix.context }}
@@ -59,7 +60,63 @@ jobs:
         if: steps.publish.outcome == 'skipped'
         uses: ./.github/workflows/template-publish-image
         with:
-          image: docker.io/kubeflow/${{ matrix.component-name }}
+          image: ghcr.io/kubeflow/trainer/${{ matrix.component-name }}
+          dockerfile: ${{ matrix.dockerfile }}
+          platforms: ${{ matrix.platforms }}
+          context: ${{ matrix.context }}
+          push: false
+
+  build-and-publish-to-dockerhub:
+    name: Build and Publish Images to DockerHub
+    runs-on:
+      labels: ubuntu-latest-16-cores
+
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - component-name: trainer-controller-manager
+            dockerfile: cmd/trainer-controller-manager/Dockerfile
+            platforms: linux/amd64,linux/arm64,linux/ppc64le
+          - component-name: model-initializer
+            dockerfile: cmd/initializer/model/Dockerfile
+            platforms: linux/amd64,linux/arm64
+          - component-name: dataset-initializer
+            dockerfile: cmd/initializer/dataset/Dockerfile
+            platforms: linux/amd64,linux/arm64
+          - component-name: torchtune-trainer
+            dockerfile: cmd/trainers/torchtune/Dockerfile
+            platforms: linux/amd64,linux/arm64
+
+    steps:
+      - name: Docker Hub Login
+        if: >-
+          github.repository == 'kubeflow/trainer' &&
+          (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-') || startsWith(github.ref, 'refs/tags/v'))
+        uses: docker/login-action@v3
+        with:
+          registry: docker.io
+          username: ${{ secrets.DOCKER_USERNAME }}
+          password: ${{ secrets.DOCKER_PASSWORD }}
+
+      - name: Publish Component ${{ matrix.component-name }} to Docker Hub
+        if: >-
+          github.repository == 'kubeflow/trainer' &&
+          (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-') || startsWith(github.ref, 'refs/tags/v'))
+        id: publish-dockerhub
+        uses: ./.github/workflows/template-publish-image
+        with:
+          image: docker.io/kubeflow/trainer/${{ matrix.component-name }}
+          dockerfile: ${{ matrix.dockerfile }}
+          platforms: ${{ matrix.platforms }}
+          context: ${{ matrix.context }}
+          push: true
+
+      - name: Test Build For Component ${{ matrix.component-name }}
+        if: steps.publish.outcome == 'skipped'
+        uses: ./.github/workflows/template-publish-image
+        with:
+          image: docker.io/kubeflow/trainer/${{ matrix.component-name }}
           dockerfile: ${{ matrix.dockerfile }}
           platforms: ${{ matrix.platforms }}
           context: ${{ matrix.context }}