[policerorch]: Fix return code comparison error (sonic-net#968)

stcheng · web-flow · commit 115eca83138e · 2019-07-03T14:42:42.000-07:00
Throw error when the return code is NOT successful :(

Signed-off-by: Shu0T1an ChenG &lt;shuche@microsoft.com&gt;
diff --git a/orchagent/policerorch.cpp b/orchagent/policerorch.cpp
@@ -251,7 +251,7 @@ void PolicerOrch::doTask(Consumer &consumer)
 
             sai_status_t status = sai_policer_api->remove_policer(
                     m_syncdPolicers.at(key));
-            if (status == SAI_STATUS_SUCCESS)
+            if (status != SAI_STATUS_SUCCESS)
             {
                 SWSS_LOG_ERROR("Failed to remove policer %s, rv:%d",
                         key.c_str(), status);

Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,7 @@ void PolicerOrch::doTask(Consumer &consumer)`
`251`	`251`
`252`	`252`	`sai_status_t status = sai_policer_api->remove_policer(`
`253`	`253`	`m_syncdPolicers.at(key));`
`254`		`- if (status == SAI_STATUS_SUCCESS)`
	`254`	`+ if (status != SAI_STATUS_SUCCESS)`
`255`	`255`	`{`
`256`	`256`	`SWSS_LOG_ERROR("Failed to remove policer %s, rv:%d",`
`257`	`257`	`key.c_str(), status);`