Skip to content

Commit 015fc62

Browse files
authored
Undo skipping Vnet tests, Vrf check before enslaving (sonic-net#857)
* Undo skipping Vnet tests, VxlanMgrd merged to master * Check VRF name before setting as master
1 parent ff9b93b commit 015fc62

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

cfgmgr/intfmgr.cpp

+4-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,10 @@ bool IntfMgr::doIntfGeneralTask(const vector<string>& keys,
144144
// Set Interface VRF except for lo
145145
if (!is_lo)
146146
{
147-
setIntfVrf(alias, vrf_name);
147+
if (!vrf_name.empty())
148+
{
149+
setIntfVrf(alias, vrf_name);
150+
}
148151
m_appIntfTableProducer.set(alias, data);
149152
}
150153
else

tests/test_vnet.py

-6
Original file line numberDiff line numberDiff line change
@@ -799,8 +799,6 @@ def get_vnet_obj(self):
799799
'''
800800
Test 1 - Create Vlan Interface, Tunnel and Vnet
801801
'''
802-
# TODO: Please fix this test case.
803-
@pytest.mark.skip(reason="Starting Vxlanmgr to be merged")
804802
def test_vnet_orch_1(self, dvs, testlog):
805803
vnet_obj = self.get_vnet_obj()
806804

@@ -850,8 +848,6 @@ def test_vnet_orch_1(self, dvs, testlog):
850848
'''
851849
Test 2 - Two VNets, One HSMs per VNet
852850
'''
853-
# TODO: Please fix this test case.
854-
@pytest.mark.skip(reason="Starting Vxlanmgr to be merged")
855851
def test_vnet_orch_2(self, dvs, testlog):
856852
vnet_obj = self.get_vnet_obj()
857853

@@ -905,8 +901,6 @@ def test_vnet_orch_2(self, dvs, testlog):
905901
'''
906902
Test 3 - Two VNets, One HSMs per VNet, Peering
907903
'''
908-
# TODO: Please fix this test case.
909-
@pytest.mark.skip(reason="Starting Vxlanmgr to be merged")
910904
def test_vnet_orch_3(self, dvs, testlog):
911905
vnet_obj = self.get_vnet_obj()
912906

0 commit comments

Comments
 (0)