Merge pull request #60 from slai/google_chrome_profiles_add_path_col

google_chrome_profiles: add path column

Author: grahamgilbert

tables/chromeuserprofiles/chrome_user_profiles.go

@@ -63,6 +63,7 @@ func GoogleChromeProfilesColumns() []table.ColumnDefinition {
 		table.TextColumn("email"),
 		table.TextColumn("name"),
 		table.IntegerColumn("ephemeral"),
+		table.TextColumn("path"),
 	}
 }
 
@@ -77,18 +78,39 @@ func generateForPath(ctx context.Context, fileInfo userFileInfo) ([]map[string]s
 		return nil, errors.Wrap(err, "unmarshalling chome local state")
 	}
 
-	for _, profileInfo := range localState.Profile.InfoCache {
+	for profileDir, profileInfo := range localState.Profile.InfoCache {
+		profilePath, err := profilePathStat(fileInfo.path, profileDir)
+		if errors.Is(err, os.ErrNotExist) {
+			// the path is constructed from Chrome's internal data, so if it
+			// doesn't exist for whatever reason, just leave it blank
+			profilePath = ""
+		} else if err != nil {
+			return nil, errors.Wrap(err, "checking profile path exists")
+		}
+
 		results = append(results, map[string]string{
 			"username":  fileInfo.user,
 			"email":     profileInfo.Email,
 			"name":      profileInfo.Name,
 			"ephemeral": strconv.Itoa(btoi(profileInfo.Ephemeral)),
+			"path":      profilePath,
 		})
 	}
 
 	return results, nil
 }
 
+func profilePathStat(localStatePath, profileDir string) (string, error) {
+	localStateDir := filepath.Dir(localStatePath)
+	profilePath := filepath.Join(localStateDir, profileDir)
+
+	if _, err := os.Stat(profilePath); err != nil {
+		return "", err
+	}
+
+	return profilePath, nil
+}
+
 func GoogleChromeProfilesGenerate(ctx context.Context, queryContext table.QueryContext) ([]map[string]string, error) {
 	osChromeLocalStateDirs, ok := chromeLocalStateDirs[runtime.GOOS]
 	if !ok {

tables/chromeuserprofiles/chrome_user_profiles_test.go

@@ -17,9 +17,9 @@ func TestBtoi(t *testing.T) {
 
 func TestGoogleChromeProfilesColumns(t *testing.T) {
 	columns := GoogleChromeProfilesColumns()
-	assert.Len(t, columns, 4)
+	assert.Len(t, columns, 5)
 
-	expectedColumnNames := []string{"username", "email", "name", "ephemeral"}
+	expectedColumnNames := []string{"username", "email", "name", "ephemeral", "path"}
 	for i, column := range columns {
 		assert.Equal(t, expectedColumnNames[i], column.Name)
 	}
@@ -61,6 +61,12 @@ func TestGenerateForPath(t *testing.T) {
 	// Create a temporary directory for testing
 	tempDir := t.TempDir()
 
+	// Create a placeholder directory for one of the profiles - the name is the
+	// info_cache map key, not the 'name' value
+	profile1Path := filepath.Join(tempDir, "profile1")
+	err := os.Mkdir(profile1Path, os.ModePerm)
+	assert.NoError(t, err)
+
 	// Create a test Chrome local state file
 	localStateFile := filepath.Join(tempDir, "Local State")
 	localStateData := `{
@@ -80,7 +86,7 @@ func TestGenerateForPath(t *testing.T) {
 		}
 	}`
 
-	err := os.WriteFile(localStateFile, []byte(localStateData), os.ModePerm)
+	err = os.WriteFile(localStateFile, []byte(localStateData), os.ModePerm)
 	assert.NoError(t, err)
 
 	// Test generateForPath
@@ -99,14 +105,42 @@ func TestGenerateForPath(t *testing.T) {
 			"email":     "[email protected]",
 			"name":      "Profile 1",
 			"ephemeral": "0",
+			"path":      profile1Path,
 		},
 		{
 			"username":  "testuser",
 			"email":     "[email protected]",
 			"name":      "Profile 2",
 			"ephemeral": "1",
+			// this profile directory doesn't exist, so the path should be blank
+			"path": "",
 		},
 	}
 
 	assert.ElementsMatch(t, expectedProfiles, results)
 }
+
+func TestProfilePathStat(t *testing.T) {
+	t.Run("profile directory exists", func(t *testing.T) {
+		tempDir := t.TempDir()
+
+		localStatePath := filepath.Join(tempDir, "Local State")
+
+		profilePath := filepath.Join(tempDir, "profile1")
+		err := os.Mkdir(profilePath, os.ModePerm)
+		assert.NoError(t, err)
+
+		actual, err := profilePathStat(localStatePath, "profile1")
+		assert.NoError(t, err)
+		assert.Equal(t, profilePath, actual)
+	})
+
+	t.Run("profile directory does not exist", func(t *testing.T) {
+		tempDir := t.TempDir()
+
+		localStatePath := filepath.Join(tempDir, "Local State")
+
+		_, err := profilePathStat(localStatePath, "profile-does-not-exist")
+		assert.ErrorIs(t, err, os.ErrNotExist)
+	})
+}