fix bug in major*UpgradeAppPathExists when fetching major upgrade

Author: erikng

Nudge/Preferences/DefaultPreferencesNudge.swift

@@ -24,8 +24,8 @@ let enforceMinorUpdates = optionalFeaturesProfile?["enforceMinorUpdates"] as? Bo
 let osVersionRequirementsProfile = getOSVersionRequirementsProfile()
 let osVersionRequirementsJSON = getOSVersionRequirementsJSON()
 let majorUpgradeAppPath = osVersionRequirementsProfile?.majorUpgradeAppPath ?? osVersionRequirementsJSON?.majorUpgradeAppPath ?? ""
-let majorUpgradeAppPathExists = FileManager.default.fileExists(atPath: majorUpgradeAppPath)
-let majorUpgradeBackupAppPathExists = FileManager.default.fileExists(atPath: Utils().getBackupMajorUpgradeAppPath())
+var majorUpgradeAppPathExists = FileManager.default.fileExists(atPath: majorUpgradeAppPath)
+var majorUpgradeBackupAppPathExists = FileManager.default.fileExists(atPath: Utils().getBackupMajorUpgradeAppPath())
 let requiredInstallationDate = osVersionRequirementsProfile?.requiredInstallationDate ?? osVersionRequirementsJSON?.requiredInstallationDate ?? Date(timeIntervalSince1970: 0)
 let requiredMinimumOSVersion = osVersionRequirementsProfile?.requiredMinimumOSVersion ?? osVersionRequirementsJSON?.requiredMinimumOSVersion ?? "0.0"
 let requiredMinimumOSVersionNormalized = try! OSVersion(requiredMinimumOSVersion).description

Nudge/Utilities/SoftwareUpdate.swift

@@ -101,10 +101,12 @@ class SoftwareUpdate {
                 if task.terminationStatus != 0 {
                     softwareupdateDownloadLog.error("Error downloading software updates: \(output, privacy: .public)")
                 } else {
-                    fetchMajorUpgradeSuccessful = true
-                    let msg = "softwareupdate successfully downloaded available update application"
+                    let msg = "softwareupdate successfully downloaded available update application - updating application paths"
                     softwareupdateListLog.notice("\(msg, privacy: .public)")
                     softwareupdateDownloadLog.info("\(output, privacy: .public)")
+                    fetchMajorUpgradeSuccessful = true
+                    majorUpgradeAppPathExists = FileManager.default.fileExists(atPath: majorUpgradeAppPath)
+                    majorUpgradeBackupAppPathExists = FileManager.default.fileExists(atPath: Utils().getBackupMajorUpgradeAppPath())
                 }
             } else {
                     let msg = "device requires major upgrade but attemptToFetchMajorUpgrade is False - skipping download"