Skip to content

Commit b1aad93

Browse files
fix possible sql injection vulnerability
1 parent 8f1e837 commit b1aad93

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

Gemfile.lock

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ GIT
3131
PATH
3232
remote: .
3333
specs:
34-
devise_token_auth (0.1.31.beta8)
34+
devise_token_auth (0.1.31.beta9)
3535
devise (~> 3.3)
3636
rails (~> 4.2)
3737

app/controllers/devise_token_auth/passwords_controller.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ def create
2727
email = resource_params[:email]
2828
end
2929

30-
q = "uid='#{email}' AND provider='email'"
30+
q = "uid = ? AND provider='email'"
3131

3232
# fix for mysql default case insensitivity
3333
if ActiveRecord::Base.connection.adapter_name.downcase.starts_with? 'mysql'
34-
q = "BINARY uid='#{email}' AND provider='email'"
34+
q = "BINARY uid = ? AND provider='email'"
3535
end
3636

37-
@resource = resource_class.where(q).first
37+
@resource = resource_class.where(q, email).first
3838

3939
errors = nil
4040

app/controllers/devise_token_auth/sessions_controller.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ def create
1111
email = resource_params[:email]
1212
end
1313

14-
q = "uid='#{email}' AND provider='email'"
14+
q = "uid = ? AND provider='email'"
1515

1616
if ActiveRecord::Base.connection.adapter_name.downcase.starts_with? 'mysql'
17-
q = "BINARY uid='#{email}' AND provider='email'"
17+
q = "BINARY uid = ? AND provider='email'"
1818
end
1919

20-
@resource = resource_class.where(q).first
20+
@resource = resource_class.where(q, email).first
2121

2222
if @resource and valid_params? and @resource.valid_password?(resource_params[:password]) and @resource.confirmed?
2323
# create client id

lib/devise_token_auth/version.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module DeviseTokenAuth
2-
VERSION = "0.1.31.beta8"
2+
VERSION = "0.1.31.beta9"
33
end

0 commit comments

Comments
 (0)