Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external lego binary rather than built-in Go package #1722

Closed
stgraber opened this issue Mar 3, 2025 · 5 comments · Fixed by #1753
Closed

Use external lego binary rather than built-in Go package #1722

stgraber opened this issue Mar 3, 2025 · 5 comments · Fixed by #1753
Assignees
Labels
Easy Good for new contributors
Milestone

Comments

@stgraber
Copy link
Member

stgraber commented Mar 3, 2025

Lego with DNS-01 pulls a lot of dependencies which results in a pretty significant increase in size to the binary and ultimately our base memory footprint.

To fix that, the easiest is to interact with the external lego binary.

@stgraber stgraber added the Easy Good for new contributors label Mar 3, 2025
@stgraber stgraber added this to the incus-6.11 milestone Mar 3, 2025
@accuser
Copy link
Contributor

accuser commented Mar 11, 2025

Quite happy to take this on - it would be straightforward to change the implementation to use the lego binary. But I assume that this will require a change to the incusd package too?

@stgraber
Copy link
Member Author

@accuser once we land the change in Incus, I'll update the Zabbly packaging to include a build of lego.

@stgraber
Copy link
Member Author

@accuser assigned it to you, thanks!

@adamcstephens
Copy link
Contributor

Probably a good idea to make this new binary requirement explicit in the release notes.

@stgraber
Copy link
Member Author

Yeah, I'll try to remember to put a notes for packagers section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Good for new contributors
Development

Successfully merging a pull request may close this issue.

3 participants