Do not download instance types if cache loadable

and environment INCUS_SKIP_INSTANCE_TYPES set to true, because most enterprise
environment has no internet access, so they can put instance types in cache and
set `INCUS_SKIP_INSTANCE_TYPES = true`.

Signed-off-by: JUN JIE NAN <[email protected]>

Author: nanjj

cmd/incusd/instance_instance_types.go

@@ -153,7 +153,18 @@ func instanceRefreshTypes(ctx context.Context, s *state.State) error {
 
 	// Set an initial value from the cache
 	if instanceTypes == nil {
-		_ = instanceLoadCache()
+		instanceTypes = map[string]map[string]*instanceType{}
+	}
+
+	if len(instanceTypes) == 0 {
+		err := instanceLoadCache()
+		if err != nil {
+			logger.Error("instance load cache error", logger.Ctx{"err": err})
+		}
+	}
+
+	if len(instanceTypes) != 0 && util.IsTrue(os.Getenv("INCUS_SKIP_INSTANCE_TYPES")) {
+		return nil
 	}
 
 	// Get the list of instance type sources

doc/environment.md

@@ -40,3 +40,4 @@ Name                            | Description
 `INCUS_SECURITY_APPARMOR`       | If set to `false`, forces AppArmor off
 `INCUS_UI`                      | Path to the web UI to serve through the web server
 `INCUS_USBIDS_PATH`             | Path to the hwdata `usb.ids` file
+`INCUS_SKIP_INSTANCE_TYPES`     | Skip loadable instance types downloading if set it to `true`