incusd/db: Improve readability with eraly return

Signed-off-by: Lucas Bremgartner <[email protected]>

Author: breml

internal/server/db/query/retry.go

@@ -38,18 +38,19 @@ func Retry(ctx context.Context, f func(ctx context.Context) error) error {
 			}
 
 			// Process actual errors.
-			if IsRetriableError(err) {
-				if i == maxRetries {
-					logger.Warn("Database error, giving up", logger.Ctx{"attempt": i, "err": err})
-					break
-				}
-
-				logger.Debug("Database error, retrying", logger.Ctx{"attempt": i, "err": err})
-				time.Sleep(jitter.Deviation(nil, 0.8)(100 * time.Millisecond))
-				continue
-			} else {
+			if !IsRetriableError(err) {
 				logger.Debug("Database error", logger.Ctx{"err": err})
+				break
 			}
+
+			if i == maxRetries {
+				logger.Warn("Database error, giving up", logger.Ctx{"attempt": i, "err": err})
+				break
+			}
+
+			logger.Debug("Database error, retrying", logger.Ctx{"attempt": i, "err": err})
+			time.Sleep(jitter.Deviation(nil, 0.8)(100 * time.Millisecond))
+			continue
 		}
 		break
 	}