Skip to content

Commit e7b34d9

Browse files
beeequeuelukeed
andauthored
chore: bump oxc-transform & add oxc-minifier (#7)
* deno 2 * add task for fixing lockfile * upgrade oxc-transform, replace terser with oxc-minify * remove duplicate package from benchmarks `package-up` is `pkg-up`: https://www.npmjs.com/package/pkg-up * deno fmt * make scripts/pretest not crash if `npm/fixtures` exists * restore package.bench.ts * Apply suggestions from code review --------- Co-authored-by: Luke Edwards <[email protected]>
1 parent 57036bf commit e7b34d9

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

scripts/build.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
import { existsSync } from 'node:fs';
77
import { join, resolve } from 'node:path';
88

9-
import oxc from 'npm:oxc-transform@^0.30';
10-
import { minify } from 'npm:[email protected]';
9+
import oxc from 'npm:oxc-transform@^0.66';
10+
import { minify } from 'npm:oxc-minify@^0.66';
1111

1212
const Quiet = Deno.args.includes('--quiet');
1313

@@ -43,6 +43,8 @@ async function transform(filename: string) {
4343
let source = await Deno.readTextFile(entry);
4444

4545
let xform = oxc.transform(entry, source, {
46+
lang: 'ts',
47+
target: 'node16',
4648
typescript: {
4749
onlyRemoveTypeImports: true,
4850
declaration: {
@@ -52,7 +54,7 @@ async function transform(filename: string) {
5254
});
5355

5456
if (xform.errors.length > 0) {
55-
bail('transform', xform.errors);
57+
bail('transform', xform.errors.map((err) => err.message));
5658
}
5759

5860
let rgx = /\.tsx?$/;
@@ -68,12 +70,9 @@ async function transform(filename: string) {
6870
await Deno.writeTextFile(outfile, xform.code);
6971

7072
try {
71-
let min = await minify(xform.code, {
72-
ecma: 2020,
73-
mangle: true,
74-
compress: true,
75-
toplevel: true,
76-
module: true,
73+
let min = minify(esm, xform.code, {
74+
mangle: { toplevel: true },
75+
compress: { target: 'es2020' },
7776
});
7877
if (!min.code) throw 1;
7978

scripts/pretest.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { existsSync } from 'node:fs';
22
import { join, resolve } from 'node:path';
33
import { cp, readdir } from 'node:fs/promises';
44

5-
import oxc from 'npm:oxc-transform@^0.25';
5+
import oxc from 'npm:oxc-transform@^0.66';
66

77
// Transform all the test files
88
// NOTE: must be w/ `build` for tests to work~!
@@ -18,6 +18,9 @@ if (!existsSync(outdir)) {
1818

1919
// tests assume "fixtures" in CWD
2020
// -> there for bench & Deno runner
21+
if (existsSync(join(outdir, 'fixtures'))) {
22+
await Deno.remove(join(outdir, 'fixtures'), { recursive: true });
23+
}
2124
await cp('fixtures', outdir);
2225

2326
for (let item of await readdir(src)) {
@@ -30,7 +33,7 @@ async function transform(filename: string) {
3033
let entry = join(src, filename);
3134
let source = await Deno.readTextFile(entry);
3235

33-
let esm = oxc.transform(entry, source);
36+
let esm = oxc.transform(entry, source, { target: 'node16' });
3437
if (esm.errors.length > 0) {
3538
console.error('[oxc] error(s)\n', esm.errors.join(''));
3639
Deno.exit(1);
@@ -40,5 +43,5 @@ async function transform(filename: string) {
4043
let outfile = join(outdir, target);
4144

4245
Quiet || console.log('> writing "%s" file', target);
43-
await Deno.writeTextFile(outfile, esm.sourceText);
46+
await Deno.writeTextFile(outfile, esm.code);
4447
}

0 commit comments

Comments
 (0)