fix: handling of bare external specifier (#157)

Author: kt3k

mod_test.ts

@@ -1018,6 +1018,7 @@ Deno.test("externals", async (t) => {
     const output = res.outputFiles[0];
     assertStringIncludes(output.text, "foo:bar");
     assertStringIncludes(output.text, "foo:baz/bar");
+    assertStringIncludes(output.text, "bar");
   });
 });
 

src/plugin_deno_resolver.ts

@@ -106,21 +106,21 @@ export function denoResolverPlugin(
           return undefined;
         }
 
-        // We can then resolve the specifier relative to the referrer URL, using
-        // the workspace resolver.
-        const resolved = new URL(
-          resolver!.resolve(args.path, referrer.href),
-        );
-
         for (const externalRegexp of externalRegexps) {
-          if (externalRegexp.test(resolved.href)) {
+          if (externalRegexp.test(args.path)) {
             return {
-              path: resolved.href,
+              path: args.path,
               external: true,
             };
           }
         }
 
+        // We can then resolve the specifier relative to the referrer URL, using
+        // the workspace resolver.
+        const resolved = new URL(
+          resolver!.resolve(args.path, referrer.href),
+        );
+
         // Now pass the resolved specifier back into the resolver, for a second
         // pass. Now plugins can perform any resolution they want on the fully
         // resolved specifier.

testdata/externals.ts

@@ -1,2 +1,3 @@
 export { a } from "foo:bar";
 export { b } from "foo:baz/bar";
+export { c } from "bar";

testdata/npm/react.tsx

@@ -1,5 +1,5 @@
 /** @jsxRuntime automatic */
-/** @jsxImportSource npm:react */
-import { renderToString } from "npm:react-dom/server";
+/** @jsxImportSource npm:react@18.3.0 */
+import { renderToString } from "npm:react-dom@18.3.0/server";
 
 export default renderToString(<div>hello world</div>);